Skip to content

make AddLabel workflow work as expected#3733

Open
charlesli640 wants to merge 1 commit intomainfrom
charlesli/debug_secrets_empty
Open

make AddLabel workflow work as expected#3733
charlesli640 wants to merge 1 commit intomainfrom
charlesli/debug_secrets_empty

Conversation

@charlesli640
Copy link
Copy Markdown
Collaborator

@charlesli640 charlesli640 commented Apr 23, 2026

Description

Make Add Label workflow work - adding Label "pull ready" when PR got approved.

1.Make AddLabel workflow in chain of "MaxText Package Tests".
2.Make AddLabel workflow to fail by core.setFailed when condition is not met
3.Need >=2 approvals to set the "pull ready" label

Tests

CI/CD

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@charlesli640 charlesli640 force-pushed the charlesli/debug_secrets_empty branch 8 times, most recently from 7a34741 to 4b449ec Compare April 23, 2026 22:40
@charlesli640 charlesli640 force-pushed the charlesli/debug_secrets_empty branch 6 times, most recently from 58d39fe to 4b449ec Compare April 24, 2026 00:38
@charlesli640 charlesli640 changed the title make AddLabel job work in PR workflow make AddLabel workflow work as expected Apr 24, 2026
@charlesli640 charlesli640 force-pushed the charlesli/debug_secrets_empty branch from ee9d8c2 to e274882 Compare April 24, 2026 01:49
Comment thread .github/workflows/AddLabel.yml
Comment thread .github/workflows/AddLabel.yml Outdated
Comment thread .github/workflows/AddLabel.yml Outdated
Comment thread .github/workflows/AddLabel.yml Outdated
Comment thread .github/workflows/AddLabel.yml
@charlesli640 charlesli640 force-pushed the charlesli/debug_secrets_empty branch from e274882 to 3bd6a89 Compare April 24, 2026 17:36
@charlesli640 charlesli640 force-pushed the charlesli/debug_secrets_empty branch 3 times, most recently from 1cc0807 to 58ead6e Compare April 24, 2026 21:28
 Make AddLabel workflow in chain of "MaxText Package Tests".
 Make AddLabel workflow to fail by core.setFailed when condition is not met
@charlesli640 charlesli640 force-pushed the charlesli/debug_secrets_empty branch from 58ead6e to d38d030 Compare April 24, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants