Fix TrainDistillTest failure by removing obsolete OfflineArrayRecordIterator mock#4036
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
shralex
approved these changes
Jun 1, 2026
SurbhiJainUSC
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the outdated mock of
distillation_utils.OfflineArrayRecordIteratorintest_main_offline_mode_skips_teacher_loading.In commit 7329370, offline distillation was refactored to use MaxText's standard input pipeline (Grain) instead of the custom array record reader. This removed
OfflineArrayRecordIteratorfromdistillation_utils.py. However, the mock intrain_distill_test.pywas left in place, resulting inAttributeErrorfailures during test setup. Removing the obsolete mock restores the test suite to a passing state.FIXES: b/518933738
Tests
CI tests passing now
Checklist
gemini-reviewlabel.