Skip to content

Fix TrainDistillTest failure by removing obsolete OfflineArrayRecordIterator mock #4036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jun 2, 2026
Merged

Fix TrainDistillTest failure by removing obsolete OfflineArrayRecordIterator mock #4036

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions tests/post_training/unit/train_distill_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1047,7 +1047,6 @@ def __call__(self, input_tokens, **kwargs):
if hasattr(trainer2.checkpoint_manager, "wait_until_finished"):
trainer2.checkpoint_manager.wait_until_finished()

@mock.patch("maxtext.trainers.post_train.distillation.train_distill.distillation_utils.OfflineArrayRecordIterator")
@mock.patch("maxtext.trainers.post_train.distillation.train_distill.MaxTextDistillationTrainer")
@mock.patch("maxtext.trainers.post_train.distillation.train_distill.input_pipeline_interface.create_data_iterator")
@mock.patch("maxtext.trainers.post_train.distillation.train_distill.get_maxtext_model")
Expand All @@ -1062,7 +1061,6 @@ def test_main_offline_mode_skips_teacher_loading(
mock_get_model,
mock_create_iterator,
mock_trainer_cls,
mock_offline_iter_cls,
):
"""Verifies offline mode (offline_data_dir is set) skips teacher model loading."""
# 1. Configs
Expand Down
Loading