Skip to content

Fix MaxTextCheckpointManager pytype compilation error #4072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix MaxTextCheckpointManager pytype compilation error #4072

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/maxtext/trainers/post_train/distillation/distillation_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,14 +658,17 @@ def __init__(
super().__init__(root_directory=root_directory, options=options)
self.student_config = student_config
self._iterator = raw_iterator
self._checkpoint_manager: checkpoint.CheckpointManager | None = None

# Re-initialize internal Orbax manager with MaxText's Grain handler
# pylint: disable=access-member-before-definition
if self._checkpoint_manager is not None:
root_directory = self._checkpoint_manager.directory
if self._checkpointer is not None:
root_directory = self._checkpointer.directory

if options is None:
options = getattr(self._checkpoint_manager, "options", None)
options = getattr(self._checkpointer, "options", None) or getattr(
self._checkpointer._manager, "options", None
)

item_handlers = {
"model_params": checkpoint.PyTreeCheckpointHandler(),
Expand All @@ -675,12 +678,13 @@ def __init__(
"iter": GrainCheckpointHandler(),
}

self._checkpoint_manager.close()
self._checkpoint_manager = checkpoint.CheckpointManager(
self._checkpointer._manager.close()
self._checkpointer._manager = checkpoint.CheckpointManager(
root_directory,
item_handlers=item_handlers,
options=options,
)
self._checkpoint_manager = self._checkpointer._manager
# pylint: enable=access-member-before-definition

def save(
Expand Down
Loading