Skip to content

Remove masks and update gmm function in moe.py#4082

Open
NuojCheng wants to merge 4 commits into
mainfrom
chengnuojin-remove-mask
Open

Remove masks and update gmm function in moe.py#4082
NuojCheng wants to merge 4 commits into
mainfrom
chengnuojin-remove-mask

Conversation

@NuojCheng
Copy link
Copy Markdown
Collaborator

@NuojCheng NuojCheng commented Jun 5, 2026

Description

This PR cherrypicks proposed changes from @RissyRan in here, and do following things

  • Update gmm function in moe.py and add group_offset input
  • Remove unnecessary masks to further extend performance

FIXES: b/519220305

Tests

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 5, 2026

🤖 Hi @NuojCheng, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 5, 2026

🤖 I'm sorry @NuojCheng, but I was unable to process your request. Please see the logs for more details.

@NuojCheng NuojCheng force-pushed the chengnuojin-remove-mask branch from ade8434 to 563a28a Compare June 5, 2026 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants