Add validation to block unsupported parameters in post-training SFT, …#4097
Open
shralex wants to merge 1 commit into
Open
Add validation to block unsupported parameters in post-training SFT, …#4097shralex wants to merge 1 commit into
shralex wants to merge 1 commit into
Conversation
shralex
requested review from
A9isha,
NicoGrande,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
igorts-git,
jesselu-google,
jiangjy1982,
khatwanimohit,
richjames0,
suexu1025 and
vipannalla
as code owners
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
…RL, and DPO - SFT, RL, and DPO trainers now error out on optimizer_memory_host_offload=True since the underlying Tunix trainers do not support host offloading. - DPO and RL trainers now error out on num_vocab_tiling > 1 since they require full vocabulary projections to compute preference/policy log-probabilities, which is incompatible with vocabulary tiling. - Created unit tests for SFT, RL, and DPO validation functions to verify these restrictions.
| return trainer, mesh | ||
|
|
||
|
|
||
| def validate_config(config): |
Collaborator
There was a problem hiding this comment.
This validation block can be moved to pyconfig.py.
Collaborator
Author
There was a problem hiding this comment.
Note that this is specific to DPO / SFT / RL, while pyconfig is generic. I'm not sure we should move it there.
SurbhiJainUSC
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…RL, and DPO
FIXES: b/520780393
Tests
Added unit tests
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.