Robust list config parsing and improved SFT docs#4101
Open
shralex wants to merge 1 commit into
Open
Conversation
- Added automatic string-to-list and tuple-to-list coercion in pyconfig.py for list[str] configuration fields (train_data_columns, eval_data_columns, trainable_parameters_mask, adamw_mask) to prevent unhelpful Pydantic validation errors. - Added comprehensive unit tests in pyconfig_test.py covering 6 coercion scenarios and end-to-end integration. - Added unit tests in instruction_data_processing_test.py validating that unsupported SFT columns throw helpful, descriptive assertion errors. - Expanded docs/tutorials/posttraining/sft.md to document SFT schemas, custom chat templates, ShareGPT custom formatters, and linked a runnable example.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIXES: b/520789228
Tests
Added unit tests to cover the new code.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.