Skip to content

Fix pyconfig access regression in inference_microbenchmark_sweep #4540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
patemotter wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix pyconfig access regression in inference_microbenchmark_sweep #4540

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions src/maxtext/inference/inference_microbenchmark_sweep.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,10 @@ def main():
- flatten_microbenchmark_results: Whether or not to flatten results. Should
be true
"""
config = pyconfig.initialize(sys.argv)
base_run_name = config.run_name
base_config = pyconfig.initialize(sys.argv)
base_run_name = base_config.run_name

with open(config.inference_metadata_file, "rt", encoding="utf-8") as json_file:
with open(base_config.inference_metadata_file, "rt", encoding="utf-8") as json_file:
inference_metadata = json.load(json_file)
print(f"inference_metadata: {inference_metadata}")

Expand Down Expand Up @@ -78,12 +78,16 @@ def main():
f"{two_axis_order_product_id}-{prefill_cache_axis_order.replace(',','')}-{ar_cache_axis_order.replace(',','')}"
)
run_name = f"{base_run_name}/{run_tag}"

tensorboard_dir = os.path.join(config.base_output_directory, run_name, "tensorboard", "")
pyconfig._config.keys["prefill_cache_axis_order"] = prefill_cache_axis_order # pylint: disable=protected-access
pyconfig._config.keys["ar_cache_axis_order"] = ar_cache_axis_order # pylint: disable=protected-access
pyconfig._config.keys["tensorboard_dir"] = tensorboard_dir # pylint: disable=protected-access
pyconfig._config.keys["run_name"] = run_name # pylint: disable=protected-access
tensorboard_dir = os.path.join(base_config.base_output_directory, run_name, "tensorboard", "")

# Re-initialize configuration per sweep step using valid kwargs overrides
config = pyconfig.initialize(
sys.argv,
prefill_cache_axis_order=prefill_cache_axis_order,
ar_cache_axis_order=ar_cache_axis_order,
tensorboard_dir=tensorboard_dir,
run_name=run_name,
)

# Prepare metadata (dimensions) json for XLML
dimensions_json = {
Expand Down Expand Up @@ -114,7 +118,7 @@ def main():
"run_name": f"{run_name}",
"run_tag": f"{run_tag}",
"config_json_string": json.dumps(
pyconfig._config.keys, # pylint: disable=protected-access
config.get_keys(),
default=lambda x: f"<<non-serializable: {type(x).__qualname__}>>",
),
}
Expand Down
Loading