BEGIN_PUBLIC Enable GCM upload for slice efficiency metrics in goodput library. END_PUBLIC#11
Merged
Merged
Conversation
copybara-service
Bot
requested review from
YixuanWang-99,
abhinavclemson,
bvandermoon,
dipannita08,
richjames0 and
shralex
as code owners
July 10, 2026 19:46
copybara-service
Bot
force-pushed
the
test_945844137
branch
2 times, most recently
from
July 17, 2026 18:23
9ac8274 to
9ba9522
Compare
dipannita08
requested changes
Jul 17, 2026
dipannita08
left a comment
dipannita08
left a comment
Collaborator
There was a problem hiding this comment.
Wait until rollout completes.
copybara-service
Bot
force-pushed
the
test_945844137
branch
from
July 17, 2026 19:21
9ba9522 to
99c331e
Compare
copybara-service
Bot
changed the title
copybara-service
Bot
force-pushed
the
test_945844137
branch
4 times, most recently
from
July 23, 2026 23:54
a6a4164 to
c844857
Compare
copybara-service
Bot
changed the title
copybara-service
Bot
force-pushed
the
test_945844137
branch
3 times, most recently
from
July 24, 2026 22:31
f0618f6 to
16355c5
Compare
copybara-service
Bot
changed the title
…t library. END_PUBLIC This change uncomments the lines that append slice efficiency metrics (stepping_slice_efficiency and available_slice_efficiency) to the list of GCM metrics in both cumulative and rolling-window uploader loops. This is part of the Slice Efficiency metrics rollout following the PRD approval. Tested: - SKYBUILD=1 blaze test //third_party/py/cloud_goodput/ml_goodput_measurement/tests:monitoring_elastic_test (passed, added unit test verifying GCM upload of slice efficiency metrics) PiperOrigin-RevId: 953583619
copybara-service
Bot
force-pushed
the
test_945844137
branch
from
July 24, 2026 22:32
16355c5 to
9bdaca7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_PUBLIC Enable GCM upload for slice efficiency metrics in goodput library. END_PUBLIC
This change uncomments the lines that append slice efficiency metrics (stepping_slice_efficiency and available_slice_efficiency) to the list of GCM metrics in both cumulative and rolling-window uploader loops.
This is part of the Slice Efficiency metrics rollout following the PRD approval.
Tested: