BEGIN_PUBLIC Fix Cache Mem leak & Build GCS-Sync GoodputCache for GoodputMonitor. END_PUBLIC#12
Open
copybara-service[bot] wants to merge 1 commit into
Open
BEGIN_PUBLIC Fix Cache Mem leak & Build GCS-Sync GoodputCache for GoodputMonitor. END_PUBLIC#12copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
requested review from
YixuanWang-99,
abhinavclemson,
bvandermoon,
dipannita08,
richjames0 and
shralex
as code owners
July 23, 2026 00:49
…dputMonitor. END_PUBLIC This change mitigates the memory leak in cumulative monitoring by introducing a file-backed cache that is periodically synced to GCS. This keeps the in-memory timeline entries bounded while preserving the historical logs across disruptions and restarts. - Introduced GoodputCache to handle local file storage (JSONL format) and GCS uploads/downloads. - Updated GoodputCalculator to read/write from/to GoodputCache. - Updated GoodputMonitor to run periodic GCS syncs in the background worker. - Added cache_dir configuration to allow tests to isolate their cache directories, fixing test collision issues. - Fixed lint issues and documented new parameters. PiperOrigin-RevId: 952245487
copybara-service
Bot
force-pushed
the
test_952245487
branch
from
July 23, 2026 00:53
4934da8 to
f5f9243
Compare
copybara-service
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_PUBLIC Fix Cache Mem leak & Build GCS-Sync GoodputCache for GoodputMonitor. END_PUBLIC
This change mitigates the memory leak in cumulative monitoring by introducing a file-backed cache that is periodically synced to GCS. This keeps the in-memory timeline entries bounded while preserving the historical logs across disruptions and restarts.