Skip to content

Clean up ProfileOptions getattr usages in pathwaysutils. #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jun 4, 2026
Merged

Clean up ProfileOptions getattr usages in pathwaysutils. #237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions pathwaysutils/profiling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,8 @@ def _is_default_profile_options(
and profiler_options.python_tracer_level
== default_options.python_tracer_level
and profiler_options.duration_ms == default_options.duration_ms
and not getattr(profiler_options, "advanced_configuration", None)
and not getattr(profiler_options, "session_id", None)
and not profiler_options.advanced_configuration
and not profiler_options.session_id
)


Expand All @@ -133,9 +133,9 @@ def _create_profile_request(
return profile_request

advanced_config = None
if getattr(profiler_options, "advanced_configuration", None):
if profiler_options.advanced_configuration:
advanced_config = {}
for k, v in getattr(profiler_options, "advanced_configuration").items():
for k, v in profiler_options.advanced_configuration.items():
# Convert python dict to tensorflow.ProfileOptions.AdvancedConfigValue
# json-compatible dict
if isinstance(v, bool):
Expand Down Expand Up @@ -169,7 +169,7 @@ def _create_profile_request(
if pw_trace_opts:
xprof_options["pwTraceOptions"] = pw_trace_opts

if getattr(profiler_options, "session_id", None):
if profiler_options.session_id:
xprof_options["traceSessionName"] = profiler_options.session_id

profile_request["xprofTraceOptions"] = xprof_options
Expand Down
Loading