Fix Workload Identity check by stripping newlines (#1194)

ankitkinra · web-flow · commit 0f92c2b70a8c · 2026-07-21T07:23:01.000Z
The gcloud container clusters describe command returns the workload pool with a trailing newline. Without stripping it, the comparison with the expected workload pool fails, causing XPK to attempt to update the GKE cluster even if Workload Identity is already enabled.
diff --git a/src/xpk/core/cluster.py b/src/xpk/core/cluster.py
@@ -655,7 +655,7 @@ def is_workload_identity_enabled_on_cluster(args) -> bool:
   )
   if return_code != 0:
     xpk_exit(return_code)
-  if workload_pool == f'{args.project}.svc.id.goog':
+  if workload_pool.strip() == f'{args.project}.svc.id.goog':
     xpk_print(
         'Workload Identity Federation is enabled on the cluster, no update'
         ' needed.'

Original file line number	Diff line number	Diff line change
`@@ -655,7 +655,7 @@ def is_workload_identity_enabled_on_cluster(args) -> bool:`
`655`	`655`	`)`
`656`	`656`	`if return_code != 0:`
`657`	`657`	`xpk_exit(return_code)`
`658`		`- if workload_pool == f'{args.project}.svc.id.goog':`
	`658`	`+ if workload_pool.strip() == f'{args.project}.svc.id.goog':`
`659`	`659`	`xpk_print(`
`660`	`660`	`'Workload Identity Federation is enabled on the cluster, no update'`
`661`	`661`	`' needed.'`