[slice] New workload condition with reason for eviction#1179
Open
pajakd wants to merge 3 commits intoAI-Hypercomputer:slice-mainfrom
Open
[slice] New workload condition with reason for eviction#1179pajakd wants to merge 3 commits intoAI-Hypercomputer:slice-mainfrom
pajakd wants to merge 3 commits intoAI-Hypercomputer:slice-mainfrom
Conversation
mwielgus
reviewed
Apr 27, 2026
|
|
||
| LWSLeaderPodSetName = "leader" | ||
|
|
||
| WorkloadSliceFailureConditionType = "SliceFailure" |
There was a problem hiding this comment.
Maybe TPUSliceFailure, so it is clear what type of slice we are talking about.
| } | ||
|
|
||
| func (r *WorkloadReconciler) updateWorkloadAdmissionCheckStatus(ctx context.Context, wl *kueue.Workload, ac *kueue.AdmissionCheckState) error { | ||
| func (r *WorkloadReconciler) updateWorkloadAdmissionCheckStatus(ctx context.Context, wl *kueue.Workload, ac *kueue.AdmissionCheckState, evictedReason string) error { |
There was a problem hiding this comment.
The function updateWorkloadAdmissionCheckStatus now also manages the SliceFailure condition on the Workload. Consider renaming it to something like updateWorkloadStatus to better reflect its expanded responsibility.
| ac.State = kueue.CheckStatePending | ||
| ac.Message = api.TruncateConditionMessage(msg) | ||
| patchErr := r.updateWorkloadAdmissionCheckStatus(ctx, wl, ac) | ||
| patchErr := r.updateWorkloadAdmissionCheckStatus(ctx, wl, ac, "") |
There was a problem hiding this comment.
In the event of a slice creation failure, ac.State is set to Pending and updateWorkloadAdmissionCheckStatus is called with an empty evictedReason. This will clear any existing SliceFailure condition. Consider if we should instead report this creation failure via the SliceFailure condition as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When evicting the workload (by setting the admission check to Retry) due to some slice issue, we would like to specify the reason for eviction in a new dedicated workload condition. I identified 4 possible issues:
kubectl delete ...)Issue
Testing