fix(ci): replace useless format! with .to_string() + cargo fmt

Co-Authored-By: Kiro <noreply@anthropic.com>

Author: ZhiXiao-Lin

core/src/agent.rs

@@ -703,90 +703,89 @@ impl AgentLoop {
         }
     }
 
-/// Inspect the workspace for well-known project marker files and return a short
-/// `## Project Context` section that the agent can use without any manual configuration.
-/// Returns an empty string when the workspace type cannot be determined.
-fn detect_project_hint(workspace: &std::path::Path) -> String {
-    struct Marker {
-        file: &'static str,
-        lang: &'static str,
-        tip: &'static str,
-    }
-
-    let markers = [
-        Marker {
-            file: "Cargo.toml",
-            lang: "Rust",
-            tip: "Use `cargo build`, `cargo test`, `cargo clippy`, and `cargo fmt`. \
+    /// Inspect the workspace for well-known project marker files and return a short
+    /// `## Project Context` section that the agent can use without any manual configuration.
+    /// Returns an empty string when the workspace type cannot be determined.
+    fn detect_project_hint(workspace: &std::path::Path) -> String {
+        struct Marker {
+            file: &'static str,
+            lang: &'static str,
+            tip: &'static str,
+        }
+
+        let markers = [
+            Marker {
+                file: "Cargo.toml",
+                lang: "Rust",
+                tip: "Use `cargo build`, `cargo test`, `cargo clippy`, and `cargo fmt`. \
                   Prefer `anyhow` / `thiserror` for error handling. \
                   Follow the Microsoft Rust Guidelines (no panics in library code, \
                   async-first with Tokio).",
-        },
-        Marker {
-            file: "package.json",
-            lang: "Node.js / TypeScript",
-            tip: "Check `package.json` for the package manager (npm/yarn/pnpm/bun) \
+            },
+            Marker {
+                file: "package.json",
+                lang: "Node.js / TypeScript",
+                tip: "Check `package.json` for the package manager (npm/yarn/pnpm/bun) \
                   and available scripts. Prefer TypeScript with strict mode. \
                   Use ESM imports unless the project is CommonJS.",
-        },
-        Marker {
-            file: "pyproject.toml",
-            lang: "Python",
-            tip: "Use the package manager declared in `pyproject.toml` \
+            },
+            Marker {
+                file: "pyproject.toml",
+                lang: "Python",
+                tip: "Use the package manager declared in `pyproject.toml` \
                   (uv, poetry, hatch, etc.). Prefer type hints and async/await for I/O.",
-        },
-        Marker {
-            file: "setup.py",
-            lang: "Python",
-            tip: "Legacy Python project. Prefer type hints and async/await for I/O.",
-        },
-        Marker {
-            file: "requirements.txt",
-            lang: "Python",
-            tip: "Python project with pip-style dependencies. \
+            },
+            Marker {
+                file: "setup.py",
+                lang: "Python",
+                tip: "Legacy Python project. Prefer type hints and async/await for I/O.",
+            },
+            Marker {
+                file: "requirements.txt",
+                lang: "Python",
+                tip: "Python project with pip-style dependencies. \
                   Prefer type hints and async/await for I/O.",
-        },
-        Marker {
-            file: "go.mod",
-            lang: "Go",
-            tip: "Use `go build ./...` and `go test ./...`. \
+            },
+            Marker {
+                file: "go.mod",
+                lang: "Go",
+                tip: "Use `go build ./...` and `go test ./...`. \
                   Follow standard Go project layout. Use `gofmt` for formatting.",
-        },
-        Marker {
-            file: "pom.xml",
-            lang: "Java / Maven",
-            tip: "Use `mvn compile`, `mvn test`, `mvn package`. \
+            },
+            Marker {
+                file: "pom.xml",
+                lang: "Java / Maven",
+                tip: "Use `mvn compile`, `mvn test`, `mvn package`. \
                   Follow standard Maven project structure.",
-        },
-        Marker {
-            file: "build.gradle",
-            lang: "Java / Gradle",
-            tip: "Use `./gradlew build` and `./gradlew test`. \
+            },
+            Marker {
+                file: "build.gradle",
+                lang: "Java / Gradle",
+                tip: "Use `./gradlew build` and `./gradlew test`. \
                   Follow standard Gradle project structure.",
-        },
-        Marker {
-            file: "build.gradle.kts",
-            lang: "Kotlin / Gradle",
-            tip: "Use `./gradlew build` and `./gradlew test`. \
+            },
+            Marker {
+                file: "build.gradle.kts",
+                lang: "Kotlin / Gradle",
+                tip: "Use `./gradlew build` and `./gradlew test`. \
                   Prefer Kotlin coroutines for async work.",
-        },
-        Marker {
-            file: "CMakeLists.txt",
-            lang: "C / C++",
-            tip: "Use `cmake -B build && cmake --build build`. \
+            },
+            Marker {
+                file: "CMakeLists.txt",
+                lang: "C / C++",
+                tip: "Use `cmake -B build && cmake --build build`. \
                   Check for `compile_commands.json` for IDE tooling.",
-        },
-        Marker {
-            file: "Makefile",
-            lang: "C / C++ (or generic)",
-            tip: "Use `make` or `make <target>`. \
+            },
+            Marker {
+                file: "Makefile",
+                lang: "C / C++ (or generic)",
+                tip: "Use `make` or `make <target>`. \
                   Check available targets with `make help` or by reading the Makefile.",
-        },
-    ];
+            },
+        ];
 
-    // Check for C# / .NET — no single fixed filename, so glob for *.csproj / *.sln
-    let is_dotnet = workspace.join("*.csproj").exists()
-        || {
+        // Check for C# / .NET — no single fixed filename, so glob for *.csproj / *.sln
+        let is_dotnet = workspace.join("*.csproj").exists() || {
             // Fast check: look for any .csproj or .sln in the workspace root
             std::fs::read_dir(workspace)
                 .map(|entries| {
@@ -799,31 +798,30 @@ fn detect_project_hint(workspace: &std::path::Path) -> String {
                 .unwrap_or(false)
         };
 
-    if is_dotnet {
-        return format!(
-            "## Project Context\n\nThis is a **C# / .NET** project. \
+        if is_dotnet {
+            return "## Project Context\n\nThis is a **C# / .NET** project. \
              Use `dotnet build`, `dotnet test`, and `dotnet run`. \
              Follow C# coding conventions and async/await patterns."
-        );
-    }
+                .to_string();
+        }
 
-    for marker in &markers {
-        if workspace.join(marker.file).exists() {
-            return format!(
-                "## Project Context\n\nThis is a **{}** project. {}",
-                marker.lang, marker.tip
-            );
+        for marker in &markers {
+            if workspace.join(marker.file).exists() {
+                return format!(
+                    "## Project Context\n\nThis is a **{}** project. {}",
+                    marker.lang, marker.tip
+                );
+            }
         }
-    }
 
-    String::new()
-}
+        String::new()
+    }
 
-/// Returns `true` for errors that are likely transient (network, timeout, I/O contention).
-/// Used to annotate tool error messages so the LLM knows whether retrying is safe.
-fn is_transient_error(msg: &str) -> bool {
-    let lower = msg.to_lowercase();
-    lower.contains("timeout")
+    /// Returns `true` for errors that are likely transient (network, timeout, I/O contention).
+    /// Used to annotate tool error messages so the LLM knows whether retrying is safe.
+    fn is_transient_error(msg: &str) -> bool {
+        let lower = msg.to_lowercase();
+        lower.contains("timeout")
         || lower.contains("timed out")
         || lower.contains("connection refused")
         || lower.contains("connection reset")
@@ -836,25 +834,25 @@ fn is_transient_error(msg: &str) -> bool {
         || lower.contains("too many requests")
         || lower.contains("service unavailable")
         || lower.contains("network unreachable")
-}
+    }
 
-/// Returns `true` when a tool writes a file and is safe to run concurrently with other
-/// independent writes (no ordering dependencies, no side-channel output).
-fn is_parallel_safe_write(name: &str, _args: &serde_json::Value) -> bool {
-    matches!(
-        name,
-        "write_file" | "edit_file" | "create_file" | "append_to_file" | "replace_in_file"
-    )
-}
+    /// Returns `true` when a tool writes a file and is safe to run concurrently with other
+    /// independent writes (no ordering dependencies, no side-channel output).
+    fn is_parallel_safe_write(name: &str, _args: &serde_json::Value) -> bool {
+        matches!(
+            name,
+            "write_file" | "edit_file" | "create_file" | "append_to_file" | "replace_in_file"
+        )
+    }
 
-/// Extract the target file path from write-tool arguments so we can check for conflicts.
-fn extract_write_path(args: &serde_json::Value) -> Option<String> {
-    // write_file / create_file / append_to_file / replace_in_file use "path"
-    // edit_file uses "path" as well
-    args.get("path")
-        .and_then(|v| v.as_str())
-        .map(|s| s.to_string())
-}
+    /// Extract the target file path from write-tool arguments so we can check for conflicts.
+    fn extract_write_path(args: &serde_json::Value) -> Option<String> {
+        // write_file / create_file / append_to_file / replace_in_file use "path"
+        // edit_file uses "path" as well
+        args.get("path")
+            .and_then(|v| v.as_str())
+            .map(|s| s.to_string())
+    }
 
     /// Execute a tool through the lane queue (if configured) or directly.
     async fn execute_tool_queued_or_direct(
@@ -1992,8 +1990,7 @@ fn extract_write_path(args: &serde_json::Value) -> Option<String> {
                     paths.len() == tool_calls.len()
                         && paths.iter().collect::<std::collections::HashSet<_>>().len()
                             == paths.len()
-                }
-            {
+                } {
                 tracing::info!(
                     count = tool_calls.len(),
                     "Parallel write batch: executing {} independent file writes concurrently",