Skip to content

Commit 4e6f2f9

Browse files
committed
Remove the method isValid for Collections
1 parent 53cda3c commit 4e6f2f9

4 files changed

Lines changed: 0 additions & 20 deletions

File tree

include/podio/CollectionBase.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,6 @@ class CollectionBase {
4848

4949
virtual bool hasID() const = 0;
5050

51-
virtual bool isValid() const = 0;
52-
5351
/// number of elements in the collection
5452
virtual size_t size() const = 0;
5553

include/podio/UserDataCollection.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -157,12 +157,6 @@ class UserDataCollection : public CollectionBase {
157157
getID() != static_cast<uint32_t>(podio::ObjectID::invalid);
158158
}
159159

160-
[[deprecated("isValid will be removed, use hasID() if you want to check if it has an ID, otherwise assume the "
161-
"collection is valid")]]
162-
bool isValid() const override {
163-
return hasID();
164-
}
165-
166160
/// number of elements in the collection
167161
size_t size() const override {
168162
return _vec.size();

include/podio/detail/LinkCollectionImpl.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -261,12 +261,6 @@ class LinkCollection : public podio::CollectionBase {
261261
getID() != static_cast<uint32_t>(podio::ObjectID::invalid);
262262
}
263263

264-
[[deprecated("isValid will be removed, use hasID() if you want to check if it has an ID, otherwise assume the "
265-
"collection is valid")]]
266-
bool isValid() const override {
267-
return hasID();
268-
}
269-
270264
podio::CollectionWriteBuffers getBuffers() override {
271265
return m_storage.getCollectionBuffers(m_isSubsetColl);
272266
}

python/templates/Collection.h.jinja2

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -161,12 +161,6 @@ public:
161161
getID() != static_cast<uint32_t>(podio::ObjectID::invalid);
162162
}
163163

164-
[[deprecated("isValid will be removed, use hasID() if you want to check if it has an ID, otherwise assume the "
165-
"collection is valid")]]
166-
bool isValid() const final {
167-
return hasID();
168-
}
169-
170164
size_t getDatamodelRegistryIndex() const final;
171165

172166
// support for the iterator protocol

0 commit comments

Comments
 (0)