Extract common members into a common base - #954
Merged
Conversation
Members related to file version and datamodels contained in files are the same for all readers and some commonly available member functions are also shared across all readers.
jmcarcell
force-pushed
the
extract-reader-common
branch
from
July 27, 2026 06:59
c3aceb0 to
b113abf
Compare
jmcarcell
marked this pull request as ready for review
July 27, 2026 07:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Members related to file version and datamodels contained in files are the same for all readers and some commonly available member functions are also shared across all readers.
BEGINRELEASENOTES
ReaderCommonutility class.ENDRELEASENOTES
Somewhat useful output regardless of whether #953 gets merged or not.