Stylistic fixes and addition of multi-modal scaffolding#810
Draft
isaacmg wants to merge 3 commits into
Draft
Conversation
isaacmg
commented
Nov 5, 2024
Collaborator
Author
There was a problem hiding this comment.
We can add the code for LANISTR, however this PR will NOT actually support its execution.
Collaborator
Author
There was a problem hiding this comment.
On this note we should "noqa" this entire file
isaacmg
commented
Nov 5, 2024
| @@ -0,0 +1 @@ | |||
| # PreDiff is on hold as it very complicated and will take a while to implement. | |||
Collaborator
Author
There was a problem hiding this comment.
Yes this will serve as placeholder until we figure out how to add stable diffusion models into FF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request does several different things:
(1) It begins to refactor some of our data-loaders and docstrings
(2) It start to properly log statements using the log functions.
(3) Add scaffolding for multi-modal data loaders
(4) Adds multimodal models outlined