Fix: Path Traversal in preview-server.ts (Arbitrary File Read)#382
Open
AmirGhMohseni wants to merge 3 commits intoAIxBlock-2023:mainfrom
Open
Fix: Path Traversal in preview-server.ts (Arbitrary File Read)#382AmirGhMohseni wants to merge 3 commits intoAIxBlock-2023:mainfrom
AmirGhMohseni wants to merge 3 commits intoAIxBlock-2023:mainfrom
Conversation
Added validation and security features for serving preview files. Signed-off-by: Amir <98203210+AmirGhMohseni@users.noreply.github.com>
Signed-off-by: Amir <98203210+AmirGhMohseni@users.noreply.github.com>
Issue 383 Signed-off-by: Amir <98203210+AmirGhMohseni@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the critical Path Traversal vulnerability reported in issue https://github.com/AIxBlock-2023/awesome-ai-dev-platform-opensource/issues/381#issue-3676632156.
Changes
path.resolve()SAFE_PREVIEW_DIR)..or absolute paths.png,.pdf)Testing
../../../etc/passwd)This patch ensures attackers cannot read arbitrary files like
.envor internal configs via the preview endpoint.