feat(flux): common diffusion module (embeddings, normalization, DiT block)#810
Draft
jasainio wants to merge 1 commit into
Draft
feat(flux): common diffusion module (embeddings, normalization, DiT block)#810jasainio wants to merge 1 commit into
jasainio wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of an 18-PR series splitting the Flux diffusion-training feature (training Flux, a DiT text-to-image diffusion model, on Primus/Megatron) out of one large branch for reviewability. Targets
feat/flux/core— review after it. Parent of the Flux model PR.What this changes
The model-agnostic diffusion building blocks shared by all diffusion models: the common diffusion module, diffusion config/embeddings/normalization, and the diffusion transformer (DiT) block. Also lands the shared diffusion test scaffolding (
conftest/helpers/constants) the later diffusion PRs reuse.Dependencies
Sequenced after the CI-pins PR (
feat/flux/ci-env); builds onfeat/flux/core.Test plan
pytest tests/unit_tests/backends/megatron/diffusion -k "embeddings or normalization". Validated locally on an AMD GPU container: 7 passed.Files
14 (common diffusion module, embeddings/normalization/config, DiT block, shared diffusion test scaffolding).