feat(flux): diffusion data pipeline (energon/synthetic providers, encoders)#812
Open
jasainio wants to merge 7 commits into
Open
feat(flux): diffusion data pipeline (energon/synthetic providers, encoders)#812jasainio wants to merge 7 commits into
jasainio wants to merge 7 commits into
Conversation
resolved requirement conflict to keep both changes
luiza-amd
force-pushed
the
feat/flux/data
branch
from
fe189a6 to
4d726d7
Compare
luiza-amd
requested review from
Xiaoming-AMD,
limou102 and
wenxie-amd
as code owners
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Unused import logging Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of an 18-PR series splitting the Flux diffusion-training feature (training Flux, a DiT text-to-image diffusion model, on Primus/Megatron) out of one large branch for reviewability. Targets
feat/flux/flux— review after it.What this changes
The diffusion data layer: dataloader + CUDA prefetch, energon and synthetic dataset providers, the image (VAE) and text (CLIP-L, T5-XXL) encoders, and the image task encoder. Also moves the energon/webdataset pins into
requirements.txthere, since this layer's source and tests need them at runtime.Why it's stacked here
One synthetic-dataset module top-level-imports
flux.utils, so it bases onfeat/flux/flux(this also transitively re-parents the prep/trainers/mlperf layers onto the Flux branch).Dependencies
Sequenced after the CI-pins PR (
feat/flux/ci-env); builds onfeat/flux/flux.Test plan
pytest tests/unit_tests/backends/megatron/diffusion/data(needsmegatron-energon/webdatasetfrom the movedrequirements.txt). Validated locally on an AMD GPU container: 50 passed.Files
32 (dataloader/prefetch, dataset providers, VAE/CLIP/T5 encoders, task encoder,
requirements.txt+ tests).