feat(flux): mxfp4 local-spec extension + fp4 utils/enums#814
Merged
Conversation
luiza-amd
force-pushed
the
feat/flux/turbo
branch
from
59e5c59 to
13ed880
Compare
luiza-amd
force-pushed
the
feat/flux/mxfp4
branch
from
8650770 to
5f79de0
Compare
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
luiza-amd
requested review from
Xiaoming-AMD,
limou102 and
wenxie-amd
as code owners
Xiaoming-AMD
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of an 18-PR series splitting the Flux diffusion-training feature (training Flux, a DiT text-to-image diffusion model, on Primus/Megatron) out of one large branch for reviewability. Targets
feat/flux/turbo— review after it.What this changes
The mxfp4 (4-bit) local-spec turbo extension plus the supporting fp4 utils and enums.
Dependencies
Builds on the CI-pins PR (
feat/flux/ci-env) — this is the path that hard-needs the bumped Primus-Turbo (its head carries that pin; that PR merges first): on the old pin it fails withgemm_fp4_impl(...)"expected at most 10 args but received 11" (the concrete motivation for the CI-pins PR). Also builds onfeat/flux/turbo.Test plan
pytest tests/unit_tests/backends/megatron/diffusion -k "mxfp4 or fp4_utils". Validated locally on an AMD GPU container: 7 passed.Files
5 (mxfp4 local-spec extension, fp4 utils, enums + tests).