misc: amd-apml: Integrate SBTSI with common device registration framework

Add device registration/unregistration calls to SBTSI drivers. This
enables Alert_L driver to discover and safely access registered TSI
devices for processing temperature alerts.

Remove device tree matching functions from SBTSI drivers that are no
longer needed after migrating Alert_L driver to use the global device
registry from apml_common framework.

The legacy Alert_L module used *_match_i2c/*_match_i3c functions to
retrieve device node information from device tree nodes. With the new
design, Alert_L module devices are now registered during each module's
probe function, making the old matching functions obsolete.

Reviewed-by: Naveen Krishna Chatradhi <naveenkrishna.chatradhi@amd.com>
Signed-off-by: sathya priya kumar <SathyaPriya.K@amd.com>
Signed-off-by: Akshay Gupta <akshay.gupta@amd.com>

Author: sathyapk

drivers/misc/amd-apml/Kconfig

@@ -29,6 +29,7 @@ config APML_SBRMI
 config APML_SBTSI
     tristate "Emulated SB-TSI interface driver over i3c bus"
     depends on I3C && !SENSORS_SBTSI
+    depends on APML_COMMON
     select REGMAP_I3C if I3C
     help
       If you say yes here you get support for emulated TSI

drivers/misc/amd-apml/apml_sbtsi.c

@@ -23,9 +23,10 @@
 #include <linux/of.h>
 #include <linux/regmap.h>
 #include <linux/version.h>
-#include <linux/amd-apml.h>
 
-#include "sbtsi-common.h"
+#include  <linux/amd-apml.h>
+#include "apml_common.h"
+
 /*
  * SB-TSI registers only support SMBus byte data access. "_INT" registers are
  * the integer part of a temperature value or limit, and "_DEC" registers are
@@ -475,6 +476,7 @@ static int sbtsi_i3c_probe(struct i3c_device *i3cdev)
 	};
 	struct regmap *regmap;
 	const char *hwmon_dev_name;
+	int ret;
 
 	dev_err(dev, "SBTSI: PID: %llx\n", i3cdev->desc->info.pid);
 	if (!(I3C_PID_INSTANCE_ID(i3cdev->desc->info.pid) == 0 ||
@@ -524,7 +526,16 @@ static int sbtsi_i3c_probe(struct i3c_device *i3cdev)
 		return PTR_ERR_OR_ZERO(hwmon_dev);
 	}
 
-	return create_misc_tsi_device(tsi_dev, dev);
+	ret = create_misc_tsi_device(tsi_dev, dev);
+	if (ret)
+		return ret;
+
+	/* Register with ALERT_L common system */
+	ret = apml_register_sbtsi_device(tsi_dev);
+	if (ret)
+		dev_warn(dev, "Failed to register with ALERT_L common system: %d\n", ret);
+
+	return 0;
 }
 
 #if LINUX_VERSION_CODE < KERNEL_VERSION(6, 3, 0)
@@ -542,6 +553,7 @@ static int sbtsi_i2c_probe(struct i2c_client *client)
 		.val_bits = 8,
 	};
 	const char *hwmon_dev_name;
+	int ret;
 
 	tsi_dev = devm_kzalloc(dev, sizeof(struct apml_sbtsi_device), GFP_KERNEL);
 	if (!tsi_dev)
@@ -568,7 +580,16 @@ static int sbtsi_i2c_probe(struct i2c_client *client)
 	if (!hwmon_dev)
 		return PTR_ERR_OR_ZERO(hwmon_dev);
 
-	return create_misc_tsi_device(tsi_dev, dev);
+	ret = create_misc_tsi_device(tsi_dev, dev);
+	if (ret)
+		return ret;
+
+	/* Register with ALERT_L common system */
+	ret = apml_register_sbtsi_device(tsi_dev);
+	if (ret)
+		dev_warn(dev, "Failed to register with ALERT_L common system: %d\n", ret);
+
+	return 0;
 }
 
 #if LINUX_VERSION_CODE < KERNEL_VERSION(5, 12, 0)
@@ -579,8 +600,10 @@ static void sbtsi_i3c_remove(struct i3c_device *i3cdev)
 {
 	struct apml_sbtsi_device *tsi_dev = dev_get_drvdata(&i3cdev->dev);
 
-	if (tsi_dev)
+	if (tsi_dev) {
+		apml_unregister_sbtsi_device(tsi_dev);
 		misc_deregister(&tsi_dev->sbtsi_misc_dev);
+	}
 
 	dev_info(&i3cdev->dev, "Removed sbtsi-i3c driver\n");
 #if LINUX_VERSION_CODE < KERNEL_VERSION(5, 12, 0)
@@ -596,8 +619,10 @@ static void sbtsi_i2c_remove(struct i2c_client *client)
 {
 	struct apml_sbtsi_device *tsi_dev = dev_get_drvdata(&client->dev);
 
-	if (tsi_dev)
+	if (tsi_dev) {
+		apml_unregister_sbtsi_device(tsi_dev);
 		misc_deregister(&tsi_dev->sbtsi_misc_dev);
+	}
 
 	dev_info(&client->dev, "Removed sbtsi driver\n");
 #if LINUX_VERSION_CODE < KERNEL_VERSION(6, 1, 0)
@@ -657,26 +682,6 @@ static struct i2c_driver sbtsi_driver = {
 
 module_i3c_i2c_driver(sbtsi_i3c_driver, &sbtsi_driver)
 
-int sbtsi_match_i3c(struct device *dev, const void *data)
-{
-	const struct device_node *node = (const struct device_node *)data;
-
-	if (dev->of_node == node && dev->driver == &sbtsi_i3c_driver.driver)
-		return 1;
-	return 0;
-}
-EXPORT_SYMBOL_GPL(sbtsi_match_i3c);
-
-int sbtsi_match_i2c(struct device *dev, const void *data)
-{
-	const struct device_node *node = (const struct device_node *)data;
-
-	if (dev->of_node == node && dev->driver == &sbtsi_driver.driver)
-		return 1;
-	return 0;
-}
-EXPORT_SYMBOL_GPL(sbtsi_match_i2c);
-
 MODULE_AUTHOR("Kun Yi <kunyi@google.com>");
 MODULE_DESCRIPTION("Hwmon driver for AMD SB-TSI emulated sensor");
 MODULE_LICENSE("GPL");

drivers/misc/amd-apml/sbtsi-common.h

@@ -21,7 +21,4 @@ struct apml_sbtsi_device {
 	u8 dev_static_addr;
 } __packed;
 
-int sbtsi_match_i2c(struct device *dev, const void *data);
-int sbtsi_match_i3c(struct device *dev, const void *data);
-
 #endif