drivers: hwmon: nct7363: Add Ghana fan pump config#276
Open
amd-knieman wants to merge 1 commit into
Open
Conversation
The `fan_sel_gpio` DTS configuration of `3` didn't properly handle the fan pump controller for Ghana. Add the `fan_sel_gpio` value of 255 for Ghana to indicate there is no fan select as BMC is the only controller for the pump fans. Properly configure PWM0 for P0 pump fans and PWM3 for P1 pump fans. Tested: Verified in Ghana. Could change the pump fan speed for P1. Setting the PWM for P0 no longer causes P1 PWM to be set to 0. Signed-off-by: Kyle Nieman <Kyle.Nieman@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
fan_sel_gpioDTS configuration of3didn't properly handle the fan pump controller for Ghana.Add the
fan_sel_gpiovalue of 255 for Ghana to indicate there is no fan select as BMC is the only controller for the pump fans.Properly configure PWM0 for P0 pump fans and PWM3 for P1 pump fans.
Tested:
Verified in Ghana. Could change the pump fan speed for P1. Setting the PWM for P0 no longer causes P1 PWM to be set to 0.