Skip to content

Commit 4a60b68

Browse files
committed
dmaengine: sdxi: Replace variadic sdxi_cxt_range()
Just have sdxi_cxt_range() for two values and sdxi_cxt_range_single() for one. The variadic macro cleverness isn't necessary and checkpatch complains about unused arguments: #define _sdxi_cxt_range(_1, _2, _fn, ...) _fn Signed-off-by: Nathan Lynch <nathan.lynch@amd.com>
1 parent 9de5573 commit 4a60b68

3 files changed

Lines changed: 10 additions & 19 deletions

File tree

drivers/dma/sdxi/context.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,7 @@ int sdxi_start_cxt(struct sdxi_cxt *cxt)
416416

417417
desc = sdxi_ring_resv_next(&resv);
418418
sdxi_encode_cxt_start(desc, &(const struct sdxi_cxt_start) {
419-
.range = sdxi_cxt_range(cxt->id),
419+
.range = sdxi_cxt_range_single(cxt->id),
420420
});
421421
sdxi_completion_attach(desc, sc);
422422
sdxi_desc_make_valid(desc);
@@ -450,11 +450,11 @@ void sdxi_stop_cxt(struct sdxi_cxt *cxt)
450450
sync = sdxi_ring_resv_next(&resv);
451451

452452
sdxi_encode_cxt_stop(stop, &(const struct sdxi_cxt_stop) {
453-
.range = sdxi_cxt_range(cxt->id),
453+
.range = sdxi_cxt_range_single(cxt->id),
454454
});
455455
sdxi_encode_sync(sync, &(const struct sdxi_sync) {
456456
.filter = SDXI_SYNC_FLT_STOP,
457-
.range = sdxi_cxt_range(cxt->id),
457+
.range = sdxi_cxt_range_single(cxt->id),
458458
});
459459
sdxi_completion_attach(sync, sc);
460460
sdxi_desc_make_valid(stop);

drivers/dma/sdxi/descriptor.h

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -77,27 +77,18 @@ struct sdxi_cxt_range {
7777
u16 cxt_end;
7878
};
7979

80-
static inline struct sdxi_cxt_range __sdxi_cxt_range(u16 a, u16 b)
80+
static inline struct sdxi_cxt_range sdxi_cxt_range(u16 a, u16 b)
8181
{
8282
return (struct sdxi_cxt_range) {
8383
.cxt_start = min(a, b),
8484
.cxt_end = max(a, b),
8585
};
8686
}
8787

88-
#define sdxi_cxt_range_1(_id) \
89-
({ \
90-
u16 id = (_id); \
91-
__sdxi_cxt_range(id, id); \
92-
})
93-
94-
#define sdxi_cxt_range_2(_id1, _id2) __sdxi_cxt_range(_id1, _id2)
95-
96-
#define _sdxi_cxt_range(_1, _2, _fn, ...) _fn
97-
98-
#define sdxi_cxt_range(...) \
99-
_sdxi_cxt_range(__VA_ARGS__, \
100-
sdxi_cxt_range_2, sdxi_cxt_range_1)(__VA_ARGS__)
88+
static inline struct sdxi_cxt_range sdxi_cxt_range_single(u16 nr)
89+
{
90+
return sdxi_cxt_range(nr, nr);
91+
}
10192

10293
void sdxi_serialize_nop(struct sdxi_desc *desc);
10394

drivers/dma/sdxi/descriptor_kunit.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,7 @@ static void cxt_start(struct kunit *t)
363363
{
364364
struct unpacked_desc unpacked;
365365
struct sdxi_cxt_start start = {
366-
.range = sdxi_cxt_range(2),
366+
.range = sdxi_cxt_range_single(2),
367367
};
368368
struct sdxi_desc desc;
369369

@@ -400,7 +400,7 @@ static void cxt_stop(struct kunit *t)
400400
{
401401
struct unpacked_desc unpacked;
402402
struct sdxi_cxt_stop stop = {
403-
.range = sdxi_cxt_range(2),
403+
.range = sdxi_cxt_range_single(2),
404404
};
405405
struct sdxi_desc desc;
406406

0 commit comments

Comments
 (0)