Skip to content

Commit d7a2857

Browse files
committed
dmaengine: sdxi: descriptor: Spec reference and whitespace cleanup
Cite the spec version and section; remove an unneeded blank line. Signed-off-by: Nathan Lynch <nathan.lynch@amd.com>
1 parent 740b738 commit d7a2857

1 file changed

Lines changed: 4 additions & 5 deletions

File tree

drivers/dma/sdxi/descriptor.c

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ void sdxi_serialize_nop(struct sdxi_desc *desc)
4646
FIELD_PREP(SDXI_DSC_TYPE, SDXI_DSC_OP_TYPE_DMAB));
4747
u64 csb_ptr = FIELD_PREP(SDXI_DSC_NP, 1);
4848

49-
5049
*desc = (typeof(*desc)) {
5150
.nop = (typeof(desc->nop)) {
5251
.opcode = cpu_to_le32(opcode),
@@ -67,10 +66,10 @@ int sdxi_encode_copy(struct sdxi_desc *desc, const struct sdxi_copy *params)
6766
if (err)
6867
return err;
6968
/*
70-
* Reject overlapping src and dst. Quoting "Memory Consistency
71-
* Model": "Software shall not ... overlap the source buffer,
72-
* destination buffer, Atomic Return Data, or completion
73-
* status block."
69+
* Reject overlapping src and dst. "Software ... shall not
70+
* overlap the source buffer, destination buffer, Atomic
71+
* Return Data, or completion status block." - SDXI 1.0 5.6
72+
* Memory Consistency Model
7473
*/
7574
if (range_overlaps(&(const struct range) {
7675
.start = params->src,

0 commit comments

Comments
 (0)