pldmd: Changes for 2X1P#79
Open
spargaon wants to merge 1 commit into
Open
Conversation
Changes for 2X1P and Set Event Receiver code. Rely on interface and endpoint properties to identify local BMC eid for an interface and use the eid for Set Event Receiver command instead of relying bmceid files under /var/run. Rely on UUID and Network Interface name to identify processor id such as 0 and 1 since in 2x1P mode, both the SoC emit the same UUID. Signed-off-by: Shirish Pargaonkar <Shirish.Pargaonkar@amd.com>
Collaborator
Author
Collaborator
Author
Collaborator
Author
|
<6> Received pldmMessagePollEvent for terminus 1 and eventid 0x0 |
mahkurap
requested changes
Jul 8, 2026
| for (const auto& mctpInfo : removedInfos) | ||
| { | ||
| auto eidToRemove = std::get<eid>(mctpInfo); | ||
| auto eidToRemove = std::get<0>(mctpInfo); |
Collaborator
There was a problem hiding this comment.
please check if you can access the members with the name instead of using index in a tuple?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes for 2X1P and Set Event Receiver code.
Rely on interface and endpoint properties to identify local BMC eid for an interface and use the eid for Set Event Receiver command instead of relying bmceid files under /var/run.
Rely on UUID and Network Interface name to identify processor id such as 0 and 1 since in 2x1P mode, both the SoC emit the same UUID.