Skip to content

Fix i2c_smbus_read_i2c_block_data return value check#19

Open
illiav-j wants to merge 1 commit into
AMDESE:mainfrom
illiav-j:fix-compile-error
Open

Fix i2c_smbus_read_i2c_block_data return value check#19
illiav-j wants to merge 1 commit into
AMDESE:mainfrom
illiav-j:fix-compile-error

Conversation

@illiav-j
Copy link
Copy Markdown

@illiav-j illiav-j commented Jun 26, 2024

Fixes the error when trying to build on the latest OpenBMC:

| …/src/vr_update_mps.cpp: In member function 'virtual bool vr_update_mps::crcCheckSum()':
| …/src/vr_update_mps.cpp:32:15: error: ordered comparison of pointer with integer zero ('uint8_t*' {aka 'unsigned char*'} and 'int')
|    32 |     if (rdata < SUCCESS)
| …/src/vr_update_mps.cpp: In member function 'virtual bool vr_update_mps::isUpdatable()':
| …/src/vr_update_mps.cpp:83:14: error: ordered comparison of pointer with integer zero ('uint8_t*' {aka 'unsigned char*'} and 'int')
|    83 |     if(rdata >= SUCCESS)
| …/src/vr_update_mps.cpp:95:14: error: ordered comparison of pointer with integer zero ('uint8_t*' {aka 'unsigned char*'} and 'int')
|    95 |     if(rdata >= SUCCESS)

This change has not been tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant