Skip to content

Commit 4c41251

Browse files
committed
Unset loglevel in amici.sim.sundials._swig_wrappers
This way, that logger will inherit the log level from its parents, and users can set the log level with, e.g., `logging.getLogger("amici.sim.sundials").setLevel(logging.CRITICAL)` without exposing any private modules. Related to #3081. `
1 parent 8d42dcb commit 4c41251

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

python/sdist/amici/logging.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,8 @@ def _setup_logger(
7979
f" (case-sensitive) or an integer log level."
8080
)
8181

82-
log.setLevel(level)
82+
if level is not None:
83+
log.setLevel(level)
8384

8485
py_warn_logger = logging.getLogger("py.warnings")
8586

@@ -118,7 +119,9 @@ def _setup_logger(
118119
return log
119120

120121

121-
def set_log_level(logger: logging.Logger, log_level: int | bool) -> None:
122+
def set_log_level(
123+
logger: logging.Logger, log_level: int | bool | None
124+
) -> None:
122125
if log_level is not None and log_level is not False:
123126
if isinstance(log_level, bool):
124127
log_level = logging.DEBUG

python/sdist/amici/sim/sundials/_swig_wrappers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030

3131
from . import ReturnDataView
3232

33-
logger = get_logger(__name__, log_level=logging.DEBUG)
33+
logger = get_logger(__name__, log_level=None)
3434

3535

3636
__all__ = [

0 commit comments

Comments
 (0)