Fixup sbml testsuite gradient check (#2858)

* Update testSBMLSuite.py

* Update testSBMLSuite.py

Author: FFroehlich

tests/sbml/testSBMLSuite.py

@@ -13,6 +13,8 @@
 import shutil
 from pathlib import Path
 
+import optimistix
+
 import amici
 import pandas as pd
 import pytest
@@ -21,7 +23,10 @@
 import jax.numpy as jnp
 import numpy as np
 import diffrax
-from amici.jax.petab import DEFAULT_CONTROLLER_SETTINGS
+from amici.jax.petab import (
+    DEFAULT_CONTROLLER_SETTINGS,
+    DEFAULT_ROOT_FINDER_SETTINGS,
+)
 
 from utils import (
     verify_results,
@@ -72,11 +77,6 @@ def test_sbml_testsuite_case(test_id, result_path, sbml_semantic_cases_dir):
 
         atol, rtol = apply_settings(settings, solver, model, test_id)
 
-        if test_id in sensitivity_check_cases:
-            model.requireSensitivitiesForAllParameters()
-            solver.setSensitivityOrder(amici.SensitivityOrder.first)
-            solver.setSensitivityMethod(amici.SensitivityMethod.forward)
-
         # simulate model
         rdata = amici.runAmiciSimulation(model, solver)
         if rdata["status"] != amici.AMICI_SUCCESS:
@@ -208,6 +208,7 @@ def jax_sensitivity_check(
             icoeff=DEFAULT_CONTROLLER_SETTINGS["icoeff"],
             dcoeff=DEFAULT_CONTROLLER_SETTINGS["dcoeff"],
         )
+        root_finder = optimistix.Newton(**DEFAULT_ROOT_FINDER_SETTINGS)
 
         def simulate(pars):
             x, _ = jax_model.simulate_condition(
@@ -221,6 +222,7 @@ def simulate(pars):
                 jnp.zeros((ts_jnp.shape[0], 0)),
                 solver,
                 controller,
+                root_finder,
                 diffrax.DirectAdjoint(),
                 diffrax.SteadyStateEvent(),
                 2**10,
@@ -243,8 +245,6 @@ def simulate(pars):
             rdata = amici.runAmiciSimulation(amici_model, solver_amici)
 
         np.testing.assert_allclose(x, rdata["x"], rtol=rtol, atol=atol)
-        np.testing.assert_allclose(
-            sx, rdata["sx"], rtol=rtol * tol_factor, atol=atol * tol_factor
-        )
+        np.testing.assert_allclose(sx, rdata["sx"], rtol=rtol, atol=atol)
     finally:
         shutil.rmtree(model_dir, ignore_errors=True)