Skip to content

Commit ab5f225

Browse files
authored
CI: skip unsupported Liu_IFACPapersOnLine2025 in JAX tests (#3121)
Skip the recently added `Liu_IFACPapersOnLine2025` (Benchmarking-Initiative/Benchmark-Models-PEtab#260) benchmark collection problem. Fixes the following test failure (https://github.com/AMICI-dev/AMICI/actions/runs/21275130982/job/61233254223): `FAILED tests/benchmark_models/test_petab_benchmark_jax.py::test_jax_llh[Liu_IFACPapersOnLine2025] - NotImplementedError: The JAX backend does not support event assignments with implicit triggers.`
1 parent 0d03620 commit ab5f225

1 file changed

Lines changed: 9 additions & 5 deletions

File tree

tests/benchmark_models/test_petab_benchmark_jax.py

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import logging
22
from functools import partial
33

4+
import diffrax
45
import equinox as eqx
56
import jax
67
import jax.numpy as jnp
@@ -23,8 +24,6 @@
2324
settings,
2425
)
2526

26-
import diffrax
27-
2827
jax.config.update("jax_enable_x64", True)
2928

3029

@@ -38,7 +37,12 @@ def test_jax_llh(benchmark_problem):
3837
benchmark_problem
3938
)
4039

41-
to_skip = ["Smith_BMCSystBiol2013", "Oliveira_NatCommun2021", "SalazarCavazos_MBoC2020"]
40+
to_skip = [
41+
"Liu_IFACPapersOnLine2025",
42+
"Oliveira_NatCommun2021",
43+
"SalazarCavazos_MBoC2020",
44+
"Smith_BMCSystBiol2013",
45+
]
4246
if problem_id in to_skip:
4347
pytest.skip(
4448
f"Skipping {problem_id} due to non-supported events in JAX."
@@ -118,12 +122,12 @@ def test_jax_llh(benchmark_problem):
118122
(llh_jax, _), sllh_jax = eqx.filter_value_and_grad(
119123
run_simulations, has_aux=True
120124
)(
121-
jax_problem,
125+
jax_problem,
122126
max_steps=max_steps,
123127
controller=diffrax.PIDController(
124128
atol=atol,
125129
rtol=rtol,
126-
)
130+
),
127131
)
128132
else:
129133
llh_jax, _ = beartype(run_simulations)(jax_problem)

0 commit comments

Comments
 (0)