Skip to content

Add gradient checks for SBML test suite#2093

Draft
dilpath wants to merge 24 commits intomainfrom
check_grad_sbml_test_suite
Draft

Add gradient checks for SBML test suite#2093
dilpath wants to merge 24 commits intomainfrom
check_grad_sbml_test_suite

Conversation

@dilpath
Copy link
Copy Markdown
Member

@dilpath dilpath commented May 16, 2023

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented May 16, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.32%. Comparing base (8469a18) to head (7bdb35c).
⚠️ Report is 274 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2093      +/-   ##
==========================================
+ Coverage   80.30%   80.32%   +0.02%     
==========================================
  Files         328      328              
  Lines       22365    22365              
  Branches     1512     1512              
==========================================
+ Hits        17960    17965       +5     
+ Misses       4394     4389       -5     
  Partials       11       11              
Flag Coverage Δ
cpp 75.43% <ø> (ø)
cpp_python 33.85% <ø> (ø)
petab 39.34% <ø> (ø)
python 74.49% <ø> (+0.02%) ⬆️
sbmlsuite-jax 34.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl
Copy link
Copy Markdown
Member

dweindl commented Oct 4, 2023

TODO:

  • FAILED tests/testSBMLSuite.py::test_sbml_testsuite_case[2] - UserWarning: Point has no component in this direction. Set ``Computer.relative_size=False`` to avoid this. Using default small step size ``fiddy.EPSILON``: 1e-05
  • FAILED tests/testSBMLSuite.py::test_sbml_testsuite_case[51] - RuntimeWarning: Mean of empty slice
  • FAILED tests/testSBMLSuite.py::test_sbml_testsuite_case[164] - ValueError: cannot reshape array of size 2 into shape (51,2,2)
  • FAILED tests/testSBMLSuite.py::test_sbml_testsuite_case[198] - ValueError: all input arrays must have the same shape
  • For now, skip gradient checks for all models that require further hyperparameter tuning

@sonarqubecloud
Copy link
Copy Markdown

@dweindl dweindl force-pushed the check_grad_sbml_test_suite branch from 179be29 to 7bdb35c Compare June 25, 2025 13:19
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants