Skip to content

Use C++20#2660

Merged
dweindl merged 3 commits intoAMICI-dev:developfrom
dweindl:cxx20
Apr 23, 2025
Merged

Use C++20#2660
dweindl merged 3 commits intoAMICI-dev:developfrom
dweindl:cxx20

Conversation

@dweindl
Copy link
Copy Markdown
Member

@dweindl dweindl commented Mar 13, 2025

Require C++20 and use std::ranges.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 82.75862% with 10 lines in your changes missing coverage. Please review.

Project coverage is 77.85%. Comparing base (a87058e) to head (da9ab17).

Files with missing lines Patch % Lines
src/edata.cpp 28.57% 5 Missing ⚠️
src/forwardproblem.cpp 50.00% 3 Missing ⚠️
include/amici/forwardproblem.h 66.66% 1 Missing ⚠️
src/model.cpp 95.23% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2660      +/-   ##
===========================================
- Coverage    77.86%   77.85%   -0.02%     
===========================================
  Files          332      332              
  Lines        23001    23013      +12     
  Branches      1480     1479       -1     
===========================================
+ Hits         17909    17916       +7     
- Misses        5081     5086       +5     
  Partials        11       11              
Flag Coverage Δ
cpp 74.79% <82.75%> (-0.01%) ⬇️
cpp_python 33.57% <53.44%> (-0.04%) ⬇️
petab 39.37% <40.74%> (-0.04%) ⬇️
python 72.89% <81.03%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/amici.cpp 79.16% <ø> (ø)
src/hdf5.cpp 86.61% <100.00%> (+0.30%) ⬆️
src/model_dae.cpp 33.91% <100.00%> (ø)
src/model_ode.cpp 70.81% <100.00%> (ø)
src/rdata.cpp 95.62% <100.00%> (+<0.01%) ⬆️
src/solver.cpp 80.04% <100.00%> (-0.03%) ⬇️
src/splinefunctions.cpp 79.12% <100.00%> (ø)
src/steadystateproblem.cpp 85.31% <100.00%> (ø)
src/sundials_matrix_wrapper.cpp 83.69% <100.00%> (ø)
src/vector.cpp 88.04% <100.00%> (ø)
... and 4 more

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl marked this pull request as ready for review April 23, 2025 09:13
@dweindl dweindl requested a review from a team as a code owner April 23, 2025 09:13
Copy link
Copy Markdown
Member

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl enabled auto-merge April 23, 2025 10:54
@dweindl dweindl added this pull request to the merge queue Apr 23, 2025
Merged via the queue into AMICI-dev:develop with commit ff1ee23 Apr 23, 2025
20 checks passed
@dweindl dweindl deleted the cxx20 branch April 23, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants