Skip to content

Remove deprecated CLI options to amici_import_petab#2671

Merged
dweindl merged 3 commits intoAMICI-dev:developfrom
dweindl:remove_petab_import_deprecated
Apr 23, 2025
Merged

Remove deprecated CLI options to amici_import_petab#2671
dweindl merged 3 commits intoAMICI-dev:developfrom
dweindl:remove_petab_import_deprecated

Conversation

@dweindl
Copy link
Copy Markdown
Member

@dweindl dweindl commented Mar 25, 2025

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.88%. Comparing base (a87058e) to head (40ef9dd).

Files with missing lines Patch % Lines
python/sdist/amici/petab/cli/import_petab.py 0.00% 3 Missing ⚠️
python/sdist/amici/petab/sbml_import.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2671      +/-   ##
===========================================
+ Coverage    77.86%   77.88%   +0.02%     
===========================================
  Files          332      332              
  Lines        23001    22983      -18     
  Branches      1480     1480              
===========================================
- Hits         17909    17901       -8     
+ Misses        5081     5071      -10     
  Partials        11       11              
Flag Coverage Δ
cpp 74.81% <0.00%> (+0.01%) ⬆️
cpp_python 33.63% <0.00%> (+0.02%) ⬆️
petab 39.44% <0.00%> (+0.03%) ⬆️
python 72.92% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/petab/sbml_import.py 77.27% <0.00%> (+0.65%) ⬆️
python/sdist/amici/petab/cli/import_petab.py 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl self-assigned this Apr 2, 2025
@dweindl dweindl marked this pull request as ready for review April 23, 2025 10:29
@dweindl dweindl requested a review from a team as a code owner April 23, 2025 10:29
@dweindl dweindl enabled auto-merge April 23, 2025 12:01
@dweindl dweindl added this pull request to the merge queue Apr 23, 2025
Merged via the queue into AMICI-dev:develop with commit 2ae76c4 Apr 23, 2025
19 of 20 checks passed
@dweindl dweindl deleted the remove_petab_import_deprecated branch April 23, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants