Skip to content

SBML import: Handle unsolvable event triggers#2686

Merged
dweindl merged 1 commit intoAMICI-dev:developfrom
dweindl:solve_t
Apr 4, 2025
Merged

SBML import: Handle unsolvable event triggers#2686
dweindl merged 1 commit intoAMICI-dev:developfrom
dweindl:solve_t

Conversation

@dweindl
Copy link
Copy Markdown
Member

@dweindl dweindl commented Apr 4, 2025

Not all event trigger functions can be solved for time when trying to compute the trigger time. Handle sympy errors in that case.

Not all event trigger functions can be solved for `time` when trying to compute the trigger time.
Handle sympy errors in that case.
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 4, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.81%. Comparing base (ec55af6) to head (856be2e).

Files with missing lines Patch % Lines
python/sdist/amici/sbml_import.py 60.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2686      +/-   ##
===========================================
- Coverage    77.86%   77.81%   -0.05%     
===========================================
  Files          332      332              
  Lines        22995    23000       +5     
  Branches      1480     1480              
===========================================
- Hits         17905    17898       -7     
- Misses        5079     5091      +12     
  Partials        11       11              
Flag Coverage Δ
cpp 74.75% <60.00%> (-0.05%) ⬇️
cpp_python 33.61% <0.00%> (-0.01%) ⬇️
petab 39.41% <0.00%> (-0.02%) ⬇️
python 72.85% <60.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/sbml_import.py 79.32% <60.00%> (-0.10%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl marked this pull request as ready for review April 4, 2025 13:37
@dweindl dweindl requested a review from a team as a code owner April 4, 2025 13:37
@dweindl dweindl merged commit e588a9f into AMICI-dev:develop Apr 4, 2025
24 of 26 checks passed
@dweindl dweindl deleted the solve_t branch April 4, 2025 15:21
dweindl added a commit to dweindl/AMICI that referenced this pull request Apr 29, 2025
Not all event trigger functions can be solved for `time` when trying to compute the trigger time. Handle sympy errors in that case.

This location was missed in AMICI-dev#2686.
github-merge-queue Bot pushed a commit that referenced this pull request Apr 29, 2025
Not all event trigger functions can be solved for `time` when trying to compute the trigger time. Handle sympy errors in that case.

This location was missed in #2686.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants