Merged
Conversation
To prevent CI failures. See #2672.
The previously used version failed configuring with CMake>=4.
Previously this was `sbml`, which was confusing because the global `sbml` was libsbml, and `SBMLImporter.sbml` was `libsbml.Model`. Now it's also consistent across modules.
Update expected docstring format.
Not all event trigger functions can be solved for `time` when trying to compute the trigger time. Handle sympy errors in that case.
Update docstrings and annotations for sympy observables/sigmas. Related to #2568. Co-authored-by: Fabian Fröhlich <fabian.frohlich@crick.ac.uk>
Closed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2690 +/- ##
==========================================
+ Coverage 77.83% 78.01% +0.18%
==========================================
Files 332 332
Lines 22994 23001 +7
Branches 1480 1480
==========================================
+ Hits 17897 17944 +47
+ Misses 5086 5046 -40
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
FFroehlich
approved these changes
Apr 23, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



No description provided.