Skip to content

Release 0.31.2#2690

Merged
dweindl merged 13 commits intomasterfrom
release_0.31.2
Apr 23, 2025
Merged

Release 0.31.2#2690
dweindl merged 13 commits intomasterfrom
release_0.31.2

Conversation

@dweindl
Copy link
Copy Markdown
Member

@dweindl dweindl commented Apr 23, 2025

No description provided.

dweindl and others added 13 commits March 24, 2025 19:53
The previously used version failed configuring with CMake>=4.
Previously this was `sbml`, which was confusing because the global `sbml` was libsbml, and `SBMLImporter.sbml` was `libsbml.Model`.
Now it's also consistent across modules.
Update expected docstring format.
Not all event trigger functions can be solved for `time` when trying to compute the trigger time.
Handle sympy errors in that case.
Update docstrings and annotations for sympy observables/sigmas. Related to #2568.

Co-authored-by: Fabian Fröhlich <fabian.frohlich@crick.ac.uk>
@dweindl dweindl requested a review from a team as a code owner April 23, 2025 08:48
@dweindl dweindl mentioned this pull request Apr 23, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 92.85714% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.01%. Comparing base (4cda6c7) to head (f2f081e).
Report is 83 commits behind head on master.

Files with missing lines Patch % Lines
python/sdist/amici/sbml_import.py 92.10% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2690      +/-   ##
==========================================
+ Coverage   77.83%   78.01%   +0.18%     
==========================================
  Files         332      332              
  Lines       22994    23001       +7     
  Branches     1480     1480              
==========================================
+ Hits        17897    17944      +47     
+ Misses       5086     5046      -40     
  Partials       11       11              
Flag Coverage Δ
cpp 77.18% <87.80%> (+2.41%) ⬆️
cpp_python 33.61% <73.17%> (-0.01%) ⬇️
petab 39.41% <65.85%> (-0.02%) ⬇️
python 73.05% <92.85%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/de_export.py 95.35% <100.00%> (+0.01%) ⬆️
src/misc.cpp 68.31% <100.00%> (+0.31%) ⬆️
python/sdist/amici/sbml_import.py 79.61% <92.10%> (+0.19%) ⬆️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link
Copy Markdown

@dweindl dweindl merged commit a87058e into master Apr 23, 2025
54 checks passed
@dweindl dweindl deleted the release_0.31.2 branch April 23, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants