Fix Heaviside functions for <, >, >= and <=#2701
Merged
dweindl merged 4 commits intoAMICI-dev:developfrom Apr 30, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2701 +/- ##
===========================================
+ Coverage 77.91% 77.93% +0.01%
===========================================
Files 326 326
Lines 23004 23004
Branches 1479 1479
===========================================
+ Hits 17924 17928 +4
+ Misses 5069 5065 -4
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
The value at 0 for the Heaviside function was incorrectly set to 1/2, leading to incorrect simulation results. Fixes AMICI-dev#2700.
Previously, `nx_solver=0` would have in a crash when calling `amici::SUNMatrixWrapper::capacity` on `SUNMatrixWrapper` of 0-sized sparse matrix. Unrelated: Replace some unnecessary `std::vector::at` calls.
FFroehlich
approved these changes
Apr 29, 2025
dweindl
added a commit
that referenced
this pull request
Apr 30, 2025
The value at 0 of the Heaviside functions for `<`, `>` `<=`, `>=` was incorrectly set to 1/2, leading to incorrect simulation results. Fixes #2700.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value at 0 of the Heaviside functions for
<,><=,>=was incorrectly set to 1/2, leading to incorrect simulation results. Fixes #2700.Requires/includes #2703 for the test.