Skip to content

SBML import: Handle unsolvable event triggers#2705

Merged
dweindl merged 1 commit intoAMICI-dev:developfrom
dweindl:trigger_solve
Apr 29, 2025
Merged

SBML import: Handle unsolvable event triggers#2705
dweindl merged 1 commit intoAMICI-dev:developfrom
dweindl:trigger_solve

Conversation

@dweindl
Copy link
Copy Markdown
Member

@dweindl dweindl commented Apr 29, 2025

Not all event trigger functions can be solved for time when trying to compute the trigger time. Handle sympy errors in that case.

This location was missed in #2686.

Not all event trigger functions can be solved for `time` when trying to compute the trigger time. Handle sympy errors in that case.

This location was missed in AMICI-dev#2686.
@dweindl dweindl marked this pull request as ready for review April 29, 2025 12:20
@dweindl dweindl requested a review from a team as a code owner April 29, 2025 12:20
@dweindl dweindl enabled auto-merge April 29, 2025 12:20
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.89%. Comparing base (9ea6aef) to head (72d5ead).

Files with missing lines Patch % Lines
python/sdist/amici/de_model_components.py 50.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2705      +/-   ##
===========================================
- Coverage    77.91%   77.89%   -0.02%     
===========================================
  Files          326      326              
  Lines        23004    23007       +3     
  Branches      1479     1479              
===========================================
- Hits         17924    17922       -2     
- Misses        5069     5074       +5     
  Partials        11       11              
Flag Coverage Δ
cpp 74.74% <50.00%> (-0.02%) ⬇️
cpp_python 33.57% <50.00%> (-0.01%) ⬇️
petab 39.41% <0.00%> (-0.01%) ⬇️
python 72.94% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/de_model_components.py 88.53% <50.00%> (-1.08%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl self-assigned this Apr 29, 2025
@dweindl dweindl added this pull request to the merge queue Apr 29, 2025
Merged via the queue into AMICI-dev:develop with commit 1fe3a9f Apr 29, 2025
24 of 26 checks passed
@dweindl dweindl deleted the trigger_solve branch April 30, 2025 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants