SBML import: Handle unsolvable event triggers#2705
Merged
dweindl merged 1 commit intoAMICI-dev:developfrom Apr 29, 2025
Merged
Conversation
Not all event trigger functions can be solved for `time` when trying to compute the trigger time. Handle sympy errors in that case. This location was missed in AMICI-dev#2686.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2705 +/- ##
===========================================
- Coverage 77.91% 77.89% -0.02%
===========================================
Files 326 326
Lines 23004 23007 +3
Branches 1479 1479
===========================================
- Hits 17924 17922 -2
- Misses 5069 5074 +5
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
FFroehlich
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not all event trigger functions can be solved for
timewhen trying to compute the trigger time. Handle sympy errors in that case.This location was missed in #2686.