Skip to content

SBML import: Handle unsolvable event triggers #2705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dweindl merged 1 commit into from
Apr 29, 2025
Merged

SBML import: Handle unsolvable event triggers #2705

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion python/sdist/amici/de_model_components.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,7 +737,11 @@
self._initial_value = initial_value

# expression(s) for the timepoint(s) at which the event triggers
self._t_root = sp.solve(self.get_val(), amici_time_symbol)
try:
self._t_root = sp.solve(self.get_val(), amici_time_symbol)
except NotImplementedError:

Check warning on line 742 in python/sdist/amici/de_model_components.py

View check run for this annotation

Codecov / codecov/patch

python/sdist/amici/de_model_components.py#L742 

Added line #L742 was not covered by tests
# the trigger can't be solved for `t`
self._t_root = []

Check warning on line 744 in python/sdist/amici/de_model_components.py

View check run for this annotation

Codecov / codecov/patch

python/sdist/amici/de_model_components.py#L744 

Added line #L744 was not covered by tests

def get_initial_value(self) -> bool:
"""
Expand Down
Loading