Skip to content

SBML import: avoid repeated xdot==0 checks#2706

Merged
dweindl merged 2 commits intoAMICI-dev:developfrom
dweindl:perf_deltasx
Apr 30, 2025
Merged

SBML import: avoid repeated xdot==0 checks#2706
dweindl merged 2 commits intoAMICI-dev:developfrom
dweindl:perf_deltasx

Conversation

@dweindl
Copy link
Copy Markdown
Member

@dweindl dweindl commented Apr 29, 2025

Avoid checking for xdot==0 for every single event when computing deltasx.

Avoid avoid some extra matrix multiplication, which may result in undefined symbols for some funny models where xdot==0.

Update SBML test suite triggers.

dweindl added 2 commits April 29, 2025 16:09
Avoid checking for `xdot==0` for every single event when computing `deltasx`.

Avoid avoid some extra matrix multiplication, which may result in undefined symbols for some funny models where xdot==0.
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.91%. Comparing base (9ea6aef) to head (5147aa6).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2706   +/-   ##
========================================
  Coverage    77.91%   77.91%           
========================================
  Files          326      326           
  Lines        23004    23006    +2     
  Branches      1479     1479           
========================================
+ Hits         17924    17926    +2     
  Misses        5069     5069           
  Partials        11       11           
Flag Coverage Δ
cpp 74.76% <100.00%> (+<0.01%) ⬆️
cpp_python 33.59% <100.00%> (+0.01%) ⬆️
petab 39.41% <25.00%> (-0.02%) ⬇️
python 72.96% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/de_model.py 90.35% <100.00%> (+0.02%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl marked this pull request as ready for review April 29, 2025 14:59
@dweindl dweindl requested a review from a team as a code owner April 29, 2025 14:59
@dweindl dweindl self-assigned this Apr 29, 2025
@dweindl dweindl added this pull request to the merge queue Apr 30, 2025
Merged via the queue into AMICI-dev:develop with commit ce1b673 Apr 30, 2025
26 checks passed
@dweindl dweindl deleted the perf_deltasx branch April 30, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants