Skip to content

SBML import: support == operator#2708

Merged
dweindl merged 2 commits intoAMICI-dev:developfrom
dweindl:eq
May 5, 2025
Merged

SBML import: support == operator#2708
dweindl merged 2 commits intoAMICI-dev:developfrom
dweindl:eq

Conversation

@dweindl
Copy link
Copy Markdown
Member

@dweindl dweindl commented Apr 30, 2025

Adds support the the equality operator in piecewise conditions or event triggers.

Closes #2685.

Adds support the the equality operator in piecewise conditions or event triggers.
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2025

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.86%. Comparing base (9a90c24) to head (2e10b75).

Files with missing lines Patch % Lines
python/sdist/amici/import_utils.py 50.00% 2 Missing ⚠️
python/sdist/amici/sbml_import.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2708      +/-   ##
===========================================
- Coverage    77.93%   77.86%   -0.07%     
===========================================
  Files          326      326              
  Lines        23009    23014       +5     
  Branches      1479     1479              
===========================================
- Hits         17931    17920      -11     
- Misses        5067     5083      +16     
  Partials        11       11              
Flag Coverage Δ
cpp 74.72% <40.00%> (-0.07%) ⬇️
cpp_python 33.59% <20.00%> (-0.01%) ⬇️
petab 39.39% <20.00%> (-0.01%) ⬇️
python 72.92% <40.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/sbml_import.py 78.65% <0.00%> (-0.08%) ⬇️
python/sdist/amici/import_utils.py 80.80% <50.00%> (-0.64%) ⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This is the combined increase from using sbmlmath, supporting xor, and supporting ==.
@dweindl dweindl marked this pull request as ready for review April 30, 2025 13:38
@dweindl dweindl requested a review from a team as a code owner April 30, 2025 13:38
@dweindl dweindl added this pull request to the merge queue May 5, 2025
Merged via the queue into AMICI-dev:develop with commit 9028595 May 5, 2025
24 of 26 checks passed
@dweindl dweindl deleted the eq branch May 5, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants