Nodal Vector Poisson solver with EB#577
Open
ax3l wants to merge 22 commits into
Open
Conversation
Signed-off-by: S. Eric Clark <25495882+clarkse@users.noreply.github.com>
Signed-off-by: S. Eric Clark <25495882+clarkse@users.noreply.github.com>
Signed-off-by: S. Eric Clark <245461744+clarkse-he@users.noreply.github.com>
Signed-off-by: S. Eric Clark <245461744+clarkse-he@users.noreply.github.com>
…nitizlize EB. Signed-off-by: S. Eric Clark <245461744+clarkse-he@users.noreply.github.com>
Signed-off-by: S. Eric Clark <245461744+clarkse-he@users.noreply.github.com>
for more information, see https://pre-commit.ci
ax3l
commented
Jun 3, 2026
ax3l
commented
Jun 3, 2026
ax3l
commented
Jun 3, 2026
ax3l
commented
Jun 3, 2026
ax3l
commented
Jun 3, 2026
ax3l
commented
Jun 3, 2026
Comment on lines
+1
to
+5
| #!/usr/bin/env python3 | ||
| """Test VectorPoissonSolverNodal in 2D RZ — A_theta convergence study. | ||
|
|
||
| Manufactured solution: A_theta = r * sin(pi*r) * sin(pi*z) on [0,1]^2. | ||
|
|
Member
Author
There was a problem hiding this comment.
Would be nice if this was integrated in our pytest suite. Please add a def test_... entry point function.
ax3l
commented
Jun 3, 2026
Comment on lines
+1
to
+5
| #!/usr/bin/env python3 | ||
|
|
||
| """ | ||
| Self-convergence test: VectorPoissonSolverNodal with EB in 2D RZ. | ||
| ================================================================= |
Member
Author
There was a problem hiding this comment.
Would be nice if this was integrated in our pytest suite. Please add a def test_... entry point function.
ax3l
commented
Jun 3, 2026
| amrex::Real inv_dr; | ||
| amrex::Real inv_dz; | ||
|
|
||
| AMREX_GPU_DEVICE |
Member
Author
There was a problem hiding this comment.
This probably needs host-device annotation
ax3l
commented
Jun 3, 2026
| const Box& bx = mfi.validbox(); | ||
| Array4<Real> const& a = acoef.array(mfi); | ||
|
|
||
| ParallelFor(bx, [=] AMREX_GPU_DEVICE (int i, int j, int k) { |
Member
Author
There was a problem hiding this comment.
This probably needs host-device annotation
ax3l
commented
Jun 3, 2026
Comment on lines
+27
to
+29
| # RZ is a 2D concept; this test requires the 2D module. It is skipped when the | ||
| # 2D module cannot be loaded (e.g. the test suite already registered the 3D one). | ||
| amr = pytest.importorskip("amrex.space2d", exc_type=ImportError) |
Member
Author
There was a problem hiding this comment.
Seems misplaced:
____________ ERROR collecting tests/test_nodal_vector_poisson_rz.py ____________
tests/test_nodal_vector_poisson_rz.py:29: in <module>
amr = pytest.importorskip("amrex.space2d", exc_type=ImportError)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ax3l
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #548 where I have permissions to push