Added customization for Unicast DNS server IP and Port#892
Conversation
|
Hi @akanashin, thank you for your PR. Can I ask the motivation for being able to change the DNS IP address? |
|
Hey! Personally, I'm using my own DNS SD implementation so I don't need to reconfigure my system to use customized ports. Think, this feaure might be useful in some (rare) cases while not being overall bad. |
|
Hi @akanashin . Many thanks for your contribution,. After a lot of consideration it feels like too much of an edge case to justify the additional complication of the DNS configuration, and its knock on effect for other tests suites and systems that rely on DNS using the default port. |
Here I add an option to customize IP address and Port number for mock Unicast DNS server of nmos-testing-tool.
This allows for easier use of this mock:
Configure custom IP:Port for mock DNS server and use it in Your client code.
What is done: