Skip to content

refactor(fetch): drop bzr support #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ShellWen wants to merge 1 commit into from
Closed

refactor(fetch): drop bzr support #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 0 additions & 28 deletions acbs/fetch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,33 +296,6 @@ def dummy_processor(package: ACBSPackageInfo, index: int, source_name: str) -> N
return None


def bzr_fetch(info: ACBSSourceInfo, source_location: str, name: str) -> Optional[ACBSSourceInfo]:
full_path = os.path.join(source_location, name)
if not os.path.exists(full_path):
subprocess.check_call(['bzr', 'branch', '--no-tree', info.url, full_path])
else:
logging.info('Updating repository...')
subprocess.check_call(['bzr', 'pull'], cwd=full_path)
info.source_location = full_path
return info


def bzr_processor(package: ACBSPackageInfo, index: int, source_name: str) -> None:
info = package.source_uri[index]
if not info.revision:
raise ValueError(
'Please specify a specific bzr revision for this package. (BZRCO not defined)')
if not info.source_location:
raise ValueError('Where is the bzr repository?')
checkout_location = os.path.join(package.build_location, info.source_name or source_name)
logging.info('Copying bzr repository...')
shutil.copytree(info.source_location, checkout_location)
logging.info(f'Checking out bzr repository at {info.revision}')
subprocess.check_call(
['bzr', 'co', '-r', info.revision], cwd=checkout_location)
return None


def fossil_fetch(info: ACBSSourceInfo, source_location: str, name: str) -> Optional[ACBSSourceInfo]:
full_path = os.path.join(source_location, name + '.fossil')
if not os.path.exists(full_path):
Expand Down Expand Up @@ -354,7 +327,6 @@ def fossil_processor(package: ACBSPackageInfo, index: int, source_name: str) ->
handlers: Dict[str, pair_signature] = {
'GIT': (git_fetch, git_processor),
'SVN': (svn_fetch, svn_processor),
'BZR': (bzr_fetch, bzr_processor),
'HG': (hg_fetch, hg_processor),
'FOSSIL': (fossil_fetch, fossil_processor),
'TARBALL': (tarball_fetch, tarball_processor),
Expand Down
4 changes: 0 additions & 4 deletions docs/source/appendix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ Supported VCS
+------------------+------------+-------+--------+--------+----------+-----------+---------------------------------------------------------------+
| Subversion (svn) | Y | Y | Y | Y | Y | N | |
+------------------+------------+-------+--------+--------+----------+-----------+---------------------------------------------------------------+
| Baazar (bzr) | Y | Y | Y | N | Y | N | Some functionalities are not verified |
+------------------+------------+-------+--------+--------+----------+-----------+---------------------------------------------------------------+
| Fossil (fossil) | Y | Y | Y | N | Y | N | |
+------------------+------------+-------+--------+--------+----------+-----------+---------------------------------------------------------------+
| BitKeeper (bk) | N | N | N | N | N | N | Not supported |
Expand All @@ -33,8 +31,6 @@ Acceptable Prefixes for ``SRCS``
+--------+-----------------------------------------+---------------------+-----------+
| svn | Subversion (VCS) | No | |
+--------+-----------------------------------------+---------------------+-----------+
| bzr | Baazar (VCS) | No | |
+--------+-----------------------------------------+---------------------+-----------+
| fossil | Fossil (VCS) | No | |
+--------+-----------------------------------------+---------------------+-----------+
| tbl | Tarball Archives (Remote Files) | Partial | [2]_ [4]_ |
Expand Down