fix MockStorage missing append_audit_event, remove stale protocol docstrings

Author: sujalgoel

src/ghdcbot/adapters/storage/sqlite.py

@@ -541,7 +541,7 @@ def list_verified_identity_mappings(self) -> list[IdentityMapping]:
 
     def get_identity_links_for_discord_user(self, discord_user_id: str) -> list[dict]:
         """Return all identity link rows for a Discord user (verified and pending).
-        Optional method; not part of the Storage protocol. Used for /verify and /status.
+        Used for /verify and /status.
         """
         with self._connect() as conn:
             rows = conn.execute(
@@ -657,9 +657,7 @@ def update_issue_request_status(self, request_id: str, status: str) -> None:
             conn.execute("UPDATE issue_requests SET status = ? WHERE request_id = ?", (status, request_id))
 
     def append_audit_event(self, event: dict) -> None:
-        """Append a single audit event (append-only) to data_dir/audit_events.jsonl.
-        Optional method; not part of the Storage protocol.
-        """
+        """Append a single audit event (append-only) to data_dir/audit_events.jsonl."""
         path = self._db_path.parent / "audit_events.jsonl"
         payload = dict(event)
         if "timestamp" not in payload:
@@ -670,7 +668,6 @@ def append_audit_event(self, event: dict) -> None:
     def list_audit_events(self) -> list[dict]:
         """Read-only: return all audit events from audit_events.jsonl.
         Returns empty list if file doesn't exist. Does not modify data.
-        Optional method; not part of the Storage protocol.
         """
         path = self._db_path.parent / "audit_events.jsonl"
         events = []
@@ -729,7 +726,6 @@ def mark_notification_sent(
     def list_recent_notifications(self, limit: int = 1000) -> list[dict]:
         """List recent notifications (for snapshot export).
         Returns list of notification dicts, ordered by sent_at DESC.
-        Optional method; not part of the Storage protocol.
         """
         with self._connect() as conn:
             rows = conn.execute(

tests/test_snapshots.py

@@ -29,16 +29,20 @@
 
 class MockStorage:
     """Mock storage for testing."""
-    
+
     def __init__(self) -> None:
-        self.notifications = []
-    
+        self.notifications: list[dict] = []
+        self.audit_events: list[dict] = []
+
     def list_recent_notifications(self, limit: int = 1000) -> list[dict]:
         return self.notifications[:limit]
-    
+
     def list_pending_issue_requests(self) -> list[dict]:
         return []
 
+    def append_audit_event(self, event: dict) -> None:
+        self.audit_events.append(event)
+
 
 class MockGitHubWriter:
     """Mock GitHub writer for testing."""
@@ -298,6 +302,10 @@ def test_write_snapshots_enabled() -> None:
     assert "schema_version" in parsed
     assert parsed["org"] == "test-org"
 
+    # Audit event should be recorded after a successful snapshot write
+    assert len(storage.audit_events) == 1
+    assert storage.audit_events[0]["event_type"] == "snapshot_written"
+
 
 def test_write_snapshots_handles_errors() -> None:
     """Test that snapshot writing errors don't propagate."""