BUG: Why to sort in Python-side on Large Dataset

[aniket866]

Is there an existing issue for this?

• I have searched the existing issues

What happened?

Where : backend/app/database/images.py
What happened ? : images.sort(key=lambda x: x["path"]) is performed in memory in db_get_all_images.

What should be : Use ORDER BY path in the SQL query and rely on it (removing the Python-side sort).

Why?: Sorting a massive list of dictionaries in Python is CPU intensive and redundant since the DB can do it faster.

Record

• I agree to follow this project's Code of Conduct

[github-actions]

👋 Thanks for opening this issue! The maintainers will review it shortly. Till then, do not open any PR. This is a strict rule we like to follow around here :)

[aniket866]

@rahulharpal1603 What's your view on this Please feel free to assign

[tubajavedd]

Hi @rahulharpal1603 and maintainers 👋
I’d like to work on this issue by moving the sorting logic to the SQL query using ORDER BY path and removing the Python-side sort.
I can also add/update tests if needed.
May I take this up and open a PR once done? Thanks!

[aniket866]

@tubajavedd I have committed locally waiting for maintainer to allow me raise a PR

[tubajavedd]

@aniket866 Thanks for the update. Let’s wait for the maintainer’s approval to proceed with the PR.