Added custom demo configuration for SocialShareButton#138
Added custom demo configuration for SocialShareButton#138sneha-techiee wants to merge 3 commits intoAOSSIE-Org:mainfrom
Conversation
github-actions
Bot
added
no-issue-linked
WalkthroughThis PR adds a new "Sneha Custom" demo and a separate "Sneha Custom Demo" section to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📋 Issue PlannerLet us write the prompt for your AI agent so you can ship faster (with fewer bugs). View plan for ticket: ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
documentation
|
Hi maintainers! I have added a custom demo to showcase how developers can personalize the SocialShareButton. Would love your feedback! 😊 |
github-actions
Bot
added
documentation
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@index.html`:
- Around line 595-596: The HTML contains a non-descriptive placeholder comment
("THIS IS IMPORTANT") above the share button div; remove that placeholder
comment or replace it with a concise, context-specific comment that explains the
purpose of the element (for example, describing that the <div id="share-button">
is the container for the page's share controls or that scripts will inject the
share widget here) so the markup follows the Google HTML style guide.
- Around line 781-798: The two SocialShareButton initializations (containers
"#share-button" and "#demo-sneha") duplicate the same options and hardcode the
URL; create a shared config object (e.g., const sharedDemoConfig or demoConfig)
that uses the existing demoUrl for url and includes title, description,
buttonStyle, and buttonText, then instantiate each SocialShareButton by merging
the shared config with the container override (using object spread or
Object.assign) so both instances reuse the same base options and avoid drift.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 9f49f9dc-5684-40a5-af4e-1802e4edebd7
📒 Files selected for processing (1)
index.html
github-actions
Bot
added
documentation
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@index.html`:
- Around line 585-600: The change added a local demo section (the
div.demo-section containing the "🧪 Sneha Custom Demo" and the element with
id="share-button" in index.html) but does not satisfy Issue `#19` which requires
adding a tutorial integration in a different org frontend repo plus a README
demo-link PR; either remove the claim that this closes `#19` and delete or revert
the demo-section div (the demo-section / demo-grid / `#share-button` markup) from
this repo, or move the demo implementation to the target org frontend repository
and create a separate PR there that includes the demo files and an updated
README with the demo link so the issue can be properly closed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: a4f0ec8a-7404-425a-b42b-66d86a2bd5b4
📒 Files selected for processing (1)
index.html
| <!-- Sneha Custom Demo --> | ||
| <div class="demo-section"> | ||
| <h2>🧪 Sneha Custom Demo</h2> | ||
| <p>This is Sneha's custom integration demo.</p> | ||
|
|
||
| <div class="demo-grid"> | ||
| <div class="demo-item"> | ||
| <h3>My Share Button</h3> | ||
| <p>Custom example added by Sneha</p> | ||
|
|
||
| <!-- Sneha's custom share button container --> | ||
| <div id="share-button"></div> | ||
|
|
||
| </div> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
This change does not fulfill Issue #19 acceptance criteria.
Issue #19 requires a tutorial integration in a different org frontend repo plus a README demo-link PR there. Adding this section in index.html here does not satisfy that deliverable, so “closes #19” is currently unsupported by the implementation scope.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@index.html` around lines 585 - 600, The change added a local demo section
(the div.demo-section containing the "🧪 Sneha Custom Demo" and the element with
id="share-button" in index.html) but does not satisfy Issue `#19` which requires
adding a tutorial integration in a different org frontend repo plus a README
demo-link PR; either remove the claim that this closes `#19` and delete or revert
the demo-section div (the demo-section / demo-grid / `#share-button` markup) from
this repo, or move the demo implementation to the target org frontend repository
and create a separate PR there that includes the demo files and an updated
README with the demo link so the issue can be properly closed.
There was a problem hiding this comment.
Hi @coderabbitai 👋
Thanks for pointing this out!
You're right — this PR focuses on adding a custom demo within the current repository and does not fully satisfy the requirements of Issue #19.
I'll remove the “Closes #19” reference from this PR and treat this as a separate enhancement contribution.
I will work on a proper tutorial integration in a different frontend project as required for Issue #19.
Thanks for the clarification! 😊
There was a problem hiding this comment.
@sneha-techiee, thanks for the understanding and for the clear plan! 👍
To summarize the next steps:
- This PR — remove the
Closestutorial: submit an tutorial integrating our SocialShareButton with different tech stack repo from our org #19`` reference from the PR description so it's tracked as a standalone demo enhancement. - Issue
#19— create a separate PR in the target org frontend repo with the tutorial video link added to that repo's README, as the issue specifies.
Would you like me to open a new GitHub issue to track the proper Issue #19 tutorial work as a follow-up, so it doesn't get lost? Just let me know!
🧠 Learnings used
Learnt from: kpj2006
Repo: AOSSIE-Org/SocialShareButton PR: 0
File: :0-0
Timestamp: 2026-03-17T17:12:57.712Z
Learning: In AOSSIE-Org/SocialShareButton, new wrapper files (e.g., src/social-share-button-preact.jsx) added in a PR are not part of any CDN release until the next version tag is cut. When reviewing PRs that add new wrapper/source files, flag any README or index.html CDN URLs that reference a version predating the new file, and check that acquisition instructions (CDN URL, npm, or download link) are provided for the new file itself.
Learnt from: kpj2006
Repo: AOSSIE-Org/SocialShareButton PR: 0
File: :0-0
Timestamp: 2026-03-10T07:25:17.136Z
Learning: For the AOSSIE-Org/SocialShareButton repository, kpj2006 wants contributors to add proper inline comments to all methods in library source files (especially src/social-share-button.js). The preferred enforcement mechanism is CodeRabbit path-based review instructions (skills) in .coderabbit.yaml, rather than scripts or workflows. During reviews, flag any newly added or modified function that lacks a descriptive comment explaining what it does, why it exists, and its parameters/return values.
Learnt from: kpj2006
Repo: AOSSIE-Org/SocialShareButton PR: 0
File: :0-0
Timestamp: 2026-03-10T07:25:17.136Z
Learning: For the AOSSIE-Org/SocialShareButton repository, kpj2006 wants contributors to add proper inline comments to all methods in library source files (especially src/social-share-button.js). The preferred enforcement mechanism is CodeRabbit path-based review instructions (skills) in .coderabbit.yaml rather than scripts or workflows. Flag any newly added or modified function that lacks a descriptive comment during reviews.
There was a problem hiding this comment.
@sneha-techiee, sounds great — thanks for acting on this promptly! 🎉 The PR description update keeps things clean and accurately scoped. Looking forward to seeing the proper Issue #19 tutorial integration in a separate PR when you're ready!
🧠 Learnings used
Learnt from: kpj2006
Repo: AOSSIE-Org/SocialShareButton PR: 0
File: :0-0
Timestamp: 2026-03-17T17:12:57.712Z
Learning: In AOSSIE-Org/SocialShareButton, new wrapper files (e.g., src/social-share-button-preact.jsx) added in a PR are not part of any CDN release until the next version tag is cut. When reviewing PRs that add new wrapper/source files, flag any README or index.html CDN URLs that reference a version predating the new file, and check that acquisition instructions (CDN URL, npm, or download link) are provided for the new file itself.
Learnt from: kpj2006
Repo: AOSSIE-Org/SocialShareButton PR: 0
File: :0-0
Timestamp: 2026-03-10T07:25:17.136Z
Learning: For the AOSSIE-Org/SocialShareButton repository, kpj2006 wants contributors to add proper inline comments to all methods in library source files (especially src/social-share-button.js). The preferred enforcement mechanism is CodeRabbit path-based review instructions (skills) in .coderabbit.yaml, rather than scripts or workflows. During reviews, flag any newly added or modified function that lacks a descriptive comment explaining what it does, why it exists, and its parameters/return values.
Learnt from: kpj2006
Repo: AOSSIE-Org/SocialShareButton PR: 0
File: :0-0
Timestamp: 2026-03-10T07:25:17.136Z
Learning: For the AOSSIE-Org/SocialShareButton repository, kpj2006 wants contributors to add proper inline comments to all methods in library source files (especially src/social-share-button.js). The preferred enforcement mechanism is CodeRabbit path-based review instructions (skills) in .coderabbit.yaml rather than scripts or workflows. Flag any newly added or modified function that lacks a descriptive comment during reviews.
If you found this review helpful, would you consider giving us a shout-out on X?
Thank you for using CodeRabbit!
|
Hello 👋 This PR has had no activity for more than 2 weeks. If you are still working on it, please push an update or leave a comment. Ping a maintainer if you believe it is ready for review or merge! This PR will be automatically closed in 7 days if there is no further activity. |
|
Hi maintainers 👋 Just following up on this PR. Would appreciate your feedback whenever you get time. 😊 |
1 participant
✨ Contribution
This PR adds a custom demo example to the Button Styles section.
🎬 Demo Video
https://drive.google.com/file/d/1bxripZunfVYkqYD2aNJOejvloK-5OVDN/view?usp=sharing
Summary by CodeRabbit
Release Notes