Merge pull request #125 from TomHAnderson/feature/shared-type-manager3

Use shared type manager for multiple drivers

Author: TomHAnderson

src/Type/PageInfo.php

@@ -7,8 +7,6 @@
 use GraphQL\Type\Definition\ObjectType;
 use GraphQL\Type\Definition\Type;
 
-use function uniqid;
-
 class PageInfo extends ObjectType
 {
     public function __construct()
@@ -21,7 +19,7 @@ public function __construct()
              * GraphQL spec:ification.
              * https://relay.dev/graphql/connections.htm#sec-Connection-Types.Fields.PageInfo
              */
-            'name' => 'PageInfo_' . uniqid(), // must start with a letter
+            'name' => 'PageInfo',
             'description' => 'Page information',
             'fields' => [
                 'startCursor' => [

src/Type/Pagination.php

@@ -7,14 +7,12 @@
 use GraphQL\Type\Definition\InputObjectType;
 use GraphQL\Type\Definition\Type;
 
-use function uniqid;
-
 class Pagination extends InputObjectType
 {
     public function __construct()
     {
         $configuration = [
-            'name' => 'Pagination_' . uniqid(), // must start with a letter
+            'name' => 'Pagination',
             'description' => 'Pagination fields for the GraphQL Complete Connection Model',
             'fields' => [
                 'first' => [

test/Feature/Criteria/CriteriaTypeCollisionTest.php

@@ -6,6 +6,7 @@
 
 use ApiSkeletons\Doctrine\GraphQL\Config;
 use ApiSkeletons\Doctrine\GraphQL\Driver;
+use ApiSkeletons\Doctrine\GraphQL\Type\TypeManager;
 use ApiSkeletonsTest\Doctrine\GraphQL\AbstractTest;
 use ApiSkeletonsTest\Doctrine\GraphQL\Entity\Performance;
 use GraphQL\GraphQL;
@@ -19,6 +20,8 @@ public function testCriteriaTypeCollision(): void
         $driver1 = new Driver($this->getEntityManager());
         $driver2 = new Driver($this->getEntityManager(), new Config(['group' => 'ExcludeCriteriaTest']));
 
+        $driver2->set(TypeManager::class, $driver1->get(TypeManager::class));
+
         $schema = new Schema([
             'query' => new ObjectType([
                 'name' => 'query',
@@ -43,11 +46,53 @@ public function testCriteriaTypeCollision(): void
             ]),
         ]);
 
-        $query  = '{ one: performance1 ( filter: { id: { eq: 2 } } ) { edges { node { id  } } }, two: performance2 ( filter: { id: { eq: 2 } } ) { edges { node { id  } } } }';
+        $query  = '{
+            one: performance1 (
+              filter: {
+                id: {
+                  eq: 2
+                }
+              }
+            ) {
+              edges {
+                node {
+                  id
+                }
+              }
+              pageInfo {
+                hasNextPage
+              }
+            },
+            two: performance2 (
+              filter: {
+                id: {
+                  eq: 2
+                }
+              }
+            ) {
+              edges {
+                node {
+                  id
+                }
+              }
+              pageInfo {
+                hasNextPage
+              }
+            }
+        }';
         $result = GraphQL::executeQuery($schema, $query);
 
         $data = $result->toArray()['data'];
 
         $this->assertEquals($data['one']['edges'][0]['node']['id'], $data['two']['edges'][0]['node']['id']);
+        $this->assertSame($driver1->get(TypeManager::class), $driver2->get(TypeManager::class));
+        $this->assertSame(
+            $driver1->get(TypeManager::class)->get('pageinfo'),
+            $driver2->get(TypeManager::class)->get('pageinfo'),
+        );
+        $this->assertSame(
+            $driver1->get(TypeManager::class)->get('pagination'),
+            $driver2->get(TypeManager::class)->get('pagination'),
+        );
     }
 }