feat: add Kiprio.com APIs (email-validate, bizday, hash)#2503
feat: add Kiprio.com APIs (email-validate, bizday, hash)#2503ForeverTools wants to merge 9 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces three new OpenAPI 3.0.3 specifications for Kiprio's Business Days Calculator, Email Validation, and Hash & Encode APIs. The review feedback focuses on enhancing the robustness of these definitions for better client generation. Key recommendations include adding missing response content for the HMAC endpoint, defining required properties across all response schemas to ensure consistent model generation, and maintaining consistency for date formats and algorithm enums across different operations.
| default: sha256 | ||
| responses: | ||
| '200': | ||
| description: HMAC result |
There was a problem hiding this comment.
The 200 response for the /hmac endpoint is missing a content definition. Without a schema, client generators cannot produce typed responses for this operation.
description: HMAC result
content:
application/json:
schema:
type: object
required:
- input
- algo
- hash
properties:
input:
type: string
algo:
type: string
hash:
type: string| type: object | ||
| properties: | ||
| from: | ||
| type: string | ||
| to: | ||
| type: string |
There was a problem hiding this comment.
The response schema should define required properties to ensure consistent behavior in generated clients. Additionally, the from and to fields in the response should include format: date to match the input parameters.
type: object
required:
- from
- to
- business_days
- calendar_days
- country
properties:
from:
type: string
format: date
to:
type: string
format: date| type: object | ||
| properties: |
There was a problem hiding this comment.
| type: object | ||
| properties: |
| algo: | ||
| type: string | ||
| default: sha256 |
|
Updated all three specs to address the bot review feedback:
|
|
Hi! All review feedback has been addressed in the latest commit:
The specs are live and tested at |
1 similar comment
|
Hi! All review feedback has been addressed in the latest commit:
The specs are live and tested at |
|
Friendly ping — this PR has been open for 48h with all bot review items addressed. Could a maintainer take a look? Happy to make any additional changes needed. |
|
Hi maintainers — following up on this PR. All bot review feedback from gemini-code-assist has been addressed (HMAC response schema, required properties, format specifications, algo enum sync). A friendly ping was left on Jun-7 with no response yet. Would really appreciate a maintainer review when you have a moment. Happy to make any further changes needed. Thank you! |
New APIs: kiprio.com
Adding 3 APIs from Kiprio.com — a developer-focused API platform providing utility HTTP endpoints.
APIs added:
Email Validation (
/v1/email-validate)Business Days Calculator (
/v1/bizday)Hash & Encode (
/v1/hash)All specs are OpenAPI 3.0.3, served from stable URLs on kiprio.com (cPanel, 99.9% uptime).
Free demo tier on every endpoint, no key required for testing.