Skip to content

(typescript) type scrollIntoView method#537

Open
hduprat wants to merge 1 commit intoAPSL:masterfrom
hduprat:typing/scrollIntoView
Open

(typescript) type scrollIntoView method#537
hduprat wants to merge 1 commit intoAPSL:masterfrom
hduprat:typing/scrollIntoView

Conversation

@hduprat
Copy link
Copy Markdown

@hduprat hduprat commented Apr 27, 2022

I noticed the scrollIntoView method of KeyboardAwareScrollView was not typed in Typescript. I added it, using native Typescript Types from React Native in order to ensure compatibility.

It's a slightly more complete version than #378 that should have been merged back in 2019.

@hduprat
Copy link
Copy Markdown
Author

hduprat commented May 16, 2022

@alvaromb @slorber Do you have time to read this PR? If not, how can I be of help?

@TacticCoder
Copy link
Copy Markdown

TacticCoder commented May 24, 2022

@hduprat, you can use patch-package until they approve

@mjvestal
Copy link
Copy Markdown

I just ran into this issue. Without this PR, linters show an error if you try to use scrollIntoView

@slorber
Copy link
Copy Markdown
Collaborator

slorber commented Oct 26, 2022

Hi

FYI I'm not maintaining this package. It just happened that I got merge/publish access and was the last one to do a release as a service to the community, but I have never been the project maintainer and don't plan to become one. If you want PRs to be reviewed/merged/published, it's best to contact the owners of this repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants