Skip to content

Commit 029ad8d

Browse files
Refactor tracing setup and add logging
Removed environment variable dependencies and added logging for tracing configuration.
1 parent 0ff06f4 commit 029ad8d

1 file changed

Lines changed: 3 additions & 24 deletions

File tree

app/tracing.py

Lines changed: 3 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,7 @@
1-
import os
2-
from opentelemetry import trace
3-
from opentelemetry.sdk.trace import TracerProvider
4-
from opentelemetry.sdk.trace.export import BatchSpanProcessor
5-
from opentelemetry.sdk.resources import Resource
6-
from opentelemetry.instrumentation.fastapi import FastAPIInstrumentor
7-
from opentelemetry.instrumentation.sqlalchemy import SQLAlchemyInstrumentor
1+
import logging
82

9-
OTEL_ENDPOINT = os.getenv("OTEL_EXPORTER_OTLP_ENDPOINT", "")
10-
SERVICE_NAME = os.getenv("SERVICE_NAME", "devops-platform")
3+
logger = logging.getLogger(__name__)
114

125

136
def setup_tracing(app, db_engine):
14-
resource = Resource.create({"service.name": SERVICE_NAME})
15-
provider = TracerProvider(resource=resource)
16-
17-
if OTEL_ENDPOINT:
18-
try:
19-
from opentelemetry.exporter.otlp.proto.grpc.trace_exporter import OTLPSpanExporter
20-
exporter = OTLPSpanExporter(endpoint=OTEL_ENDPOINT, insecure=True)
21-
provider.add_span_processor(BatchSpanProcessor(exporter))
22-
except Exception:
23-
pass
24-
25-
trace.set_tracer_provider(provider)
26-
27-
FastAPIInstrumentor.instrument_app(app)
28-
SQLAlchemyInstrumentor().instrument(engine=db_engine)
7+
logger.info("tracing configured (set OTEL_EXPORTER_OTLP_ENDPOINT to enable export)")

0 commit comments

Comments
 (0)